r72732 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72731‎ | r72732 | r72733 >
Date:18:48, 10 September 2010
Author:reedy
Status:ok
Tags:
Comment:
Remove 2 todo's

$i doesn't exist now, it's $rating
Modified paths:
  • /trunk/extensions/ArticleAssessmentPilot/api/ApiArticleAssessment.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleAssessmentPilot/api/ApiArticleAssessment.php
@@ -23,8 +23,6 @@
2424
2525 // Query the latest ratings by this user for this page,
2626 // possibly for an older revision
27 - // TODO: Make this query saner once $wgArticleAssessmentRatingCount has been redone
28 - // TODO:Refactor out...?
2927 $res = $dbr->select(
3028 'article_assessment',
3129 array( 'aa_rating_id', 'aa_rating_value', 'aa_revision' ),
@@ -64,7 +62,7 @@
6563 $thisRating = $params["r{$rating}"];
6664 }
6765
68 - $this->insertPageRating( $pageId, $i, ( $thisRating - $lastRating ),
 66+ $this->insertPageRating( $pageId, $rating, ( $thisRating - $lastRating ),
6967 ( $lastRating === false && $thisRating !== false )
7068 );
7169

Status & tagging log