r72687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72686‎ | r72687 | r72688 >
Date:22:11, 9 September 2010
Author:demon
Status:ok
Tags:
Comment:
Fix jQuery loading
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerOutput.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerOutput.php
@@ -145,7 +145,7 @@
146146 <?php echo Html::linkedStyle( '../skins/monobook/main.css' ) . "\n"; ?>
147147 <?php echo Html::linkedStyle( '../skins/common/config.css' ) . "\n"; ?>
148148 <?php echo Html::inlineScript( "var dbTypes = " . Xml::encodeJsVar( $dbTypes ) ) . "\n"; ?>
149 - <?php $this->outputJQuery() . "\n"; ?>
 149+ <?php echo $this->getJQuery() . "\n"; ?>
150150 <?php echo Html::linkedScript( '../skins/common/config.js' ) . "\n"; ?>
151151 </head>
152152
@@ -209,7 +209,7 @@
210210 <title><?php $this->outputTitle(); ?></title>
211211 <?php echo Html::linkedStyle( '../skins/monobook/main.css' ) . "\n"; ?>
212212 <?php echo Html::linkedStyle( '../skins/common/config.css' ) . "\n"; ?>
213 - <?php $this->outputJQuery(); ?>
 213+ <?php echo $this->getJQuery(); ?>
214214 <?php echo Html::linkedScript( '../skins/common/config.js' ); ?>
215215 </head>
216216
@@ -222,9 +222,8 @@
223223 echo htmlspecialchars( wfMsg( 'config-title', $wgVersion ) );
224224 }
225225
226 - public function outputJQuery() {
227 - global $wgJQueryVersion;
228 - echo Html::linkedScript( "../skins/common/jquery-$wgJQueryVersion.min.js" );
 226+ public function getJQuery() {
 227+ return Html::linkedScript( "../resources/jquery/jquery.js" );
229228 }
230229
231230 public function outputWarnings() {

Status & tagging log