r72666 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72665‎ | r72666 | r72667 >
Date:17:57, 9 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
correct fix for r72177
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerLoader.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialBannerLoader.php
@@ -148,7 +148,7 @@
149149 private function getDonationAmount() {
150150 global $wgNoticeCounterSource, $wgMemc;
151151 // Pull short-cached amount
152 - $count = intval( wfMemcKey( 'centralnotice', 'counter' ) );
 152+ $count = intval( $wgMemc->get( wfMemcKey( 'centralnotice', 'counter' ) ) );
153153 if ( !$count ) {
154154 // Pull from dynamic counter
155155 wfSuppressWarnings();
@@ -156,7 +156,7 @@
157157 wfRestoreWarnings();
158158 if ( !$count ) {
159159 // Pull long-cached amount
160 - $count = intval( wfMemcKey( 'centralnotice', 'counter', 'fallback' ) );
 160+ $count = intval( $wgMemc->get( wfMemcKey( 'centralnotice', 'counter', 'fallback' ) ) );
161161 if ( !$count ) {
162162 // Return hard-coded amount if all else fails
163163 return 1100000; // Update as needed during fundraiser

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72177initial version of BannerLoaderkaldari23:18, 1 September 2010

Status & tagging log