r72664 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r72663‎ | r72664 | r72665 >
Date:16:48, 9 September 2010
Author:demon
Status:ok
Tags:
Comment:
Per bug 22884, using "localhost" probably won't work on Windows. However, it's not a PHP bug, or even really something we should handle. It's up to the person performing the installation to ensure a connection to MySQL exists; we shouldn't presume 127.0.0.1 is a valid replacement in all Windows scenarios. So, we'll update the help info with a friendly suggestion for those who might hit this.
Modified paths:
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.i18n.php
——@@ -172,7 +172,9 @@
173173 'config-db-host' => 'Database host:',
174174 'config-db-host-help' => 'If your database server is on different server, enter the host name or IP address here.
175175
176 -If you are using shared web hosting, your hosting provider should give you the correct host name in their documentation.',
 176+If you are using shared web hosting, your hosting provider should give you the correct host name in their documentation.
 177+
 178+If you are installing on a Windows server and using MySQL, using "localhost" may not work for the server name. If it does not, try "127.0.0.1" for the local IP address',
177179 'config-db-wiki-settings' => 'Identify this wiki',
178180 'config-db-name' => 'Database name:',
179181 'config-db-name-help' => 'Choose a name that identifies your wiki.

Status & tagging log