r72612 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72611‎ | r72612 | r72613 >
Date:22:09, 8 September 2010
Author:reedy
Status:ok
Tags:
Comment:
$limit is undefined, so we're not going to get any results (not that we use a limit anyway)

Hence fixing up my fail of limit removal
Modified paths:
  • /trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php
@@ -119,11 +119,6 @@
120120
121121 $count = 0;
122122 foreach ( $ratings as $rat ) {
123 - if ( ++ $count > $limit ) {
124 - //$this->setContinueEnumParameter( 'from', $this->keyToTitle( $row->page_title ) );
125 - break;
126 - }
127 -
128123 $result->setIndexedTagName( $rat['ratings'], 'r' );
129124 $result->addValue( array( 'query', $this->getModuleName() ), null, $rat );
130125 }

Status & tagging log