r72578 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72577‎ | r72578 | r72579 >
Date:11:25, 8 September 2010
Author:btongminh
Status:ok
Tags:
Comment:
Followup r72475: assert that a job has been popped to avoid fatals
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/UploadFromUrlTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/UploadFromUrlTest.php
@@ -244,6 +244,7 @@
245245 ) );
246246
247247 $job = Job::pop();
 248+ $this->assertEquals( 'UploadFromUrlJob', get_class( $job ) );
248249 $job->run();
249250
250251 $this->assertTrue( wfLocalFile( 'UploadFromUrlTest.png' )->exists() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72475Follow-up r70137: Made asynchronous upload working a bit more. It now fully w...btongminh10:18, 6 September 2010

Status & tagging log