r72569 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72568‎ | r72569 | r72570 >
Date:00:04, 8 September 2010
Author:tparscal
Status:ok
Tags:
Comment:
Split mediawiki.legacy.shared into mediawiki.legacy.shared and mediawiki.legacy.oldshared - as it should have been.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)
  • /trunk/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -108,7 +108,8 @@
109109 */
110110 function setupSkinUserCss( OutputPage $out ){
111111 $out->addModuleStyles( 'mediawiki.legacy.shared' );
112 - $out->addModuleStyles( 'mediawiki.legacy.commonPrint' );
 112+ // ResourceLoader does not support CSS media types yet, so we must include this on it's own the old way
 113+ $out->addStyle( 'common/commonPrint.css', 'print' );
113114 }
114115
115116 /**
Index: trunk/phase3/includes/Skin.php
@@ -723,8 +723,8 @@
724724 * @param $out OutputPage
725725 */
726726 function setupSkinUserCss( OutputPage $out ) {
727 - // This includes the shared.js and oldshared.js files from skins/common/
728727 $out->addModuleStyles( 'mediawiki.legacy.shared' );
 728+ $out->addModuleStyles( 'mediawiki.legacy.oldshared' );
729729 // TODO: Figure out how to best integrate this stuff into ResourceLoader
730730 $out->addStyle( $this->getStylesheet() );
731731 $out->addStyle( 'common/common_rtl.css', '', '', 'rtl' );
Index: trunk/phase3/resources/Resources.php
@@ -350,8 +350,11 @@
351351 'dependencies' => 'mediawiki.legacy.wikibits',
352352 ) ),
353353 'mediawiki.legacy.shared' => new ResourceLoaderFileModule( array(
354 - 'styles' => array( 'skins/common/shared.css', 'skins/common/oldshared.css' ),
 354+ 'styles' => 'skins/common/shared.css',
355355 ) ),
 356+ 'mediawiki.legacy.oldshared' => new ResourceLoaderFileModule( array(
 357+ 'styles' => 'skins/common/oldshared.css',
 358+ ) ),
356359 'mediawiki.legacy.upload' => new ResourceLoaderFileModule( array(
357360 'scripts' => 'skins/common/upload.js',
358361 'dependencies' => 'mediawiki.legacy.wikibits',

Status & tagging log