r72536 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72535‎ | r72536 | r72537 >
Date:12:48, 7 September 2010
Author:demon
Status:ok
Tags:
Comment:
Followup r72535, I suppose I shouldn't break the old installer yet
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -999,7 +999,7 @@
10001000 }
10011001
10021002 function setup_database() {
1003 - $res = $this->sourceFile( "../maintenance/ora/tables.sql" );
 1003+ $res = $this->sourceFile( "../maintenance/oracle/tables.sql" );
10041004 if ( $res === true ) {
10051005 print " done.</li>\n";
10061006 } else {
Index: trunk/phase3/config/Installer.php
@@ -1042,7 +1042,7 @@
10431043 echo "<li>Connect failed.</li>";
10441044 if ($useRoot) {
10451045 if (ini_get('oci8.privileged_connect') === false) {
1046 - echo "<li>Privileged connect disabled, please set oci8.privileged_connect or run maintenance/ora/user.sql script manually prior to continuing.</li>";
 1046+ echo "<li>Privileged connect disabled, please set oci8.privileged_connect or run maintenance/oracle/user.sql script manually prior to continuing.</li>";
10471047 $ok = false;
10481048 } else {
10491049 $wgDBadminuser = $conf->RootUser;
@@ -1052,7 +1052,7 @@
10531053 if ($wgDatabase->isOpen()) {
10541054 $wgDBOracleDefTS = $conf->DBdefTS_ora;
10551055 $wgDBOracleTempTS = $conf->DBtempTS_ora;
1056 - $res = $wgDatabase->sourceFile( "../maintenance/ora/user.sql" );
 1056+ $res = $wgDatabase->sourceFile( "../maintenance/oracle/user.sql" );
10571057 if ($res !== true) dieout($res);
10581058 } else {
10591059 echo "<li>Invalid database superuser, please supply a valid superuser account.</li>";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72535Move ora to oracle. Stuff expects these directories to match $wgDBtypedemon12:46, 7 September 2010

Status & tagging log