r72534 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72533‎ | r72534 | r72535 >
Date:12:40, 7 September 2010
Author:reedy
Status:ok
Tags:
Comment:
ApiListArticleAssessment:
*Make pageid required
*Remove isset against revid
Modified paths:
  • /trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php
@@ -20,9 +20,7 @@
2121 ),
2222 ) );
2323
24 - if ( isset( $params['pageid'] ) ) {
25 - $this->addWhereFld( 'aap_page_id', $params['pageid'] );
26 - }
 24+ $this->addWhereFld( 'aap_page_id', $params['pageid'] );
2725
2826 if ( $params['userrating'] ) {
2927 global $wgUser;
@@ -73,7 +71,7 @@
7472 'pageid' => $pageId,
7573 );
7674
77 - if ( isset( $params['revid'] ) || $params['userrating'] ) {
 75+ if ( $params['userrating'] ) {
7876 $page['revid'] = $row->aa_revision;
7977 }
8078
@@ -138,6 +136,7 @@
139137 public function getAllowedParams() {
140138 return array(
141139 'pageid' => array(
 140+ ApiBase::PARAM_REQUIRED => true,
142141 ApiBase::PARAM_ISMULTI => false,
143142 ApiBase::PARAM_TYPE => 'integer',
144143 ),

Status & tagging log