r72523 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72522‎ | r72523 | r72524 >
Date:09:40, 7 September 2010
Author:tstarling
Status:ok
Tags:
Comment:
Fix for r72371: use English in variable names.
Modified paths:
  • /trunk/extensions/PagedTiffHandler/PagedTiffHandler.image.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PagedTiffHandler/PagedTiffHandler.image.php
@@ -260,8 +260,8 @@
261261 }
262262 }
263263
264 - $ofs = (int)$m[1];
265 - $ignore = !empty( $ignoreIFDs[ $ofs ] );
 264+ $offset = (int)$m[1];
 265+ $ignore = !empty( $ignoreIFDs[ $offset ] );
266266 } else if ( preg_match('#^(TIFF.*?Directory): (.*?/.*?): (.*)#i', $row, $m) ) {
267267 $bypass = false;
268268 $msg = $m[3];
@@ -294,8 +294,8 @@
295295 } else if ( preg_match('/.*IFDOffset/', $key) ) {
296296 # ignore extra IFDs, see <http://www.awaresystems.be/imaging/tiff/tifftags/exififd.html>
297297 # Note: we assume that we will always see the reference before the actual IFD, so we know which IFDs to ignore
298 - $ofs = (int)$value;
299 - $ignoreIFDs[$ofs] = true;
 298+ $offset = (int)$value;
 299+ $ignoreIFDs[$offset] = true;
300300 }
301301 } else {
302302 // strange line

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72371replacement for r72279: ignore extra IFDs reported by tiffinfodaniel12:48, 4 September 2010

Status & tagging log