r72519 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72518‎ | r72519 | r72520 >
Date:07:51, 7 September 2010
Author:siebrand
Status:deferred
Tags:
Comment:
Remove deprecated old style message group class OpenLayersMessageGroup. Using YAML.
Modified paths:
  • /trunk/extensions/Translate/_autoload.php (modified) (history)
  • /trunk/extensions/Translate/groups/OpenLayers.php (deleted) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/OpenLayers.php
@@ -1,57 +0,0 @@
2 -<?php
3 -/**
4 - * Support for OpenLayers.
5 - *
6 - * @file
7 - * @author Robert Leverington <robert@rhl.me.uk>
8 - * @copyright Copyright © 2009 Robert Leverington
9 - * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
10 - */
11 -
12 -/**
13 - * %Message group for OpenLayers.
14 - * @todo Use new style group configuration.
15 - * @todo Use new style class OpenLayersFFS.
16 - */
17 -class OpenLayersMessageGroup extends MessageGroupOld {
18 - protected $label = 'OpenLayers';
19 - protected $id = 'out-openlayers';
20 - protected $type = 'openlayers';
21 -
22 - protected $fileDir = '__BUG__';
23 -
24 - public function getPath() { return $this->fileDir; }
25 - public function setPath( $value ) { $this->fileDir = $value; }
26 -
27 - protected $codeMap = array(
28 - 'cs' => 'cs-CZ',
29 - 'da' => 'da-DK',
30 - 'pt-br' => 'pt-BR',
31 - 'sv' => 'sv-SE',
32 - 'zh-hans' => 'zh-CN',
33 - 'zh-tw' => 'zh-TW',
34 - );
35 -
36 - protected $ignored = array(
37 - 'end'
38 - );
39 -
40 - public function getMessageFile( $code ) {
41 - if ( isset( $this->codeMap[ $code ] ) ) {
42 - $code = $this->codeMap[ $code ];
43 - }
44 - return "$code.js";
45 - }
46 -
47 - protected function getFileLocation( $code ) {
48 - return $this->fileDir . '/' . $this->getMessageFile( $code );
49 - }
50 -
51 - public function getReader( $code ) {
52 - return new OpenLayersFormatReader( $this->getFileLocation( $code ) );
53 - }
54 -
55 - public function getWriter() {
56 - return new OpenLayersFormatWriter( $this );
57 - }
58 -}
Index: trunk/extensions/Translate/_autoload.php
@@ -123,7 +123,6 @@
124124 $wgAutoloadClasses['AllMediawikiExtensionsGroup'] = $dir . 'groups/MediaWikiExtensions.php';
125125 $wgAutoloadClasses['PremadeMediawikiExtensionGroups'] = $dir . 'groups/MediaWikiExtensions.php';
126126 $wgAutoloadClasses['PremadeWikiaExtensionGroups'] = $dir . 'groups/Wikia/WikiaExtensions.php';
127 -$wgAutoloadClasses['OpenLayersMessageGroup'] = $dir . 'groups/OpenLayers.php';
128127 $wgAutoloadClasses['MediaWikiMessageChecker'] = $dir . 'groups/MediaWiki/Checker.php';
129128 /**@}*/
130129

Follow-up revisions

RevisionCommit summaryAuthorDate
r72521Follow-up r72519: also remove old OpenLayers FFS classes.siebrand08:32, 7 September 2010

Status & tagging log