r72504 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72503‎ | r72504 | r72505 >
Date:18:28, 6 September 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r72497
Modified paths:
  • /trunk/extensions/Maps/includes/Maps_Mapper.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/Maps_Mapper.php
@@ -85,9 +85,10 @@
8686 */
8787 public static function formatLocation( &$location, $name, array $parameters ) {
8888 if ( self::geocoderIsAvailable() ) {
89 - $geoService = array_key_exists( 'geoservice', $parameters ) ? $parameters['geoservice']['value'] : '';
90 - $mappingService = array_key_exists( 'mappingservice', $parameters ) ? $parameters['mappingservice']['value'] : false;
91 - $location = MapsGeocoders::attemptToGeocodeToString( $location, $geoService, $mappingService );
 89+ // TODO
 90+ //$geoService = array_key_exists( 'geoservice', $parameters ) ? $parameters['geoservice']['value'] : '';
 91+ //$mappingService = array_key_exists( 'mappingservice', $parameters ) ? $parameters['mappingservice']['value'] : false;
 92+ $location = MapsGeocoders::attemptToGeocodeToString( $location/*, $geoService, $mappingService*/ );
9293 } else {
9394 $location = MapsCoordinateParser::parseAndFormat( $location );
9495 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72497Changes for 0.7 - matching changes made in Validatorjeroendedauw16:17, 6 September 2010

Status & tagging log