r72456 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72455‎ | r72456 | r72457 >
Date:20:43, 5 September 2010
Author:simetrical
Status:ok
Tags:
Comment:
Get rid of Language::usesFirstLettersInLists()

Added by me in r69810, but never used. It's not clear to me if it's
needed, but if so, it can be re-added later.
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
@@ -2967,18 +2967,6 @@
29682968 }
29692969
29702970 /**
2971 - * Does it make sense for lists to be split up into sections based on their
2972 - * first letter? Logogram-based scripts probably want to return false.
2973 - *
2974 - * TODO: Use this in CategoryPage.php.
2975 - *
2976 - * @return boolean
2977 - */
2978 - public function usesFirstLettersInLists() {
2979 - return true;
2980 - }
2981 -
2982 - /**
29832971 * Given a string, return the logical "first letter" to be used for
29842972 * grouping on category pages and so on. This has to be coordinated
29852973 * carefully with convertToSortkey(), or else the sorted list might jump
@@ -2997,7 +2985,6 @@
29982986 * * [[Ape]]
29992987 *
30002988 * etc., assuming for the sake of argument that $wgCapitalLinks is false.
3001 - * Obviously, this is ignored if usesFirstLettersInLists() is false.
30022989 *
30032990 * @param string $string UTF-8 string
30042991 * @return string UTF-8 string corresponding to the first letter of input

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69810Initial commit for category collation framework...simetrical19:52, 23 July 2010

Status & tagging log