r72433 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72432‎ | r72433 | r72434 >
Date:14:29, 5 September 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r72432
Modified paths:
  • /trunk/extensions/Maps/Includes/Maps_Mapper.php (modified) (history)
  • /trunk/extensions/Maps/Maps.php (modified) (history)
  • /trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMaps.php
@@ -48,7 +48,8 @@
4949 Validator::addOutputFormat( 'gmaptype', array( __CLASS__, 'setGMapType' ) );
5050 Validator::addOutputFormat( 'gmaptypes', array( __CLASS__, 'setGMapTypes' ) );
5151
52 - Validator::addValidationFunction( 'is_google_overlay', array( __CLASS__, 'isGOverlay' ) );
 52+ // TODO
 53+ //Validator::addValidationFunction( 'is_google_overlay', array( __CLASS__, 'isGOverlay' ) );
5354
5455 $allowedTypes = self::getTypeNames();
5556
Index: trunk/extensions/Maps/Includes/Maps_Mapper.php
@@ -17,9 +17,11 @@
1818 * or formatting functions are handled.
1919 */
2020 public static function initialize() {
 21+ /* TODO
2122 Validator::addValidationFunction( 'is_map_dimension', array( __CLASS__, 'isMapDimension' ) );
2223 Validator::addValidationFunction( 'is_location', array( __CLASS__, 'isLocation' ) );
2324 Validator::addValidationFunction( 'are_locations', array( __CLASS__, 'areLocations' ) );
 25+ */
2426
2527 Validator::addOutputFormat( 'mapdimension', array( __CLASS__, 'setMapDimension' ) );
2628 Validator::addOutputFormat( 'coordinateSet', array( __CLASS__, 'formatLocation' ) );
Index: trunk/extensions/Maps/Maps.php
@@ -36,7 +36,7 @@
3737 echo '<b>Warning:</b> You need to have <a href="http://www.mediawiki.org/wiki/Extension:Validator">Validator</a> installed in order to use <a href="http://www.mediawiki.org/wiki/Extension:Maps">Maps</a>.';
3838 }
3939 else {
40 - define( 'Maps_VERSION', '0.7 alpha-2' );
 40+ define( 'Maps_VERSION', '0.7 alpha-4' );
4141
4242 // The different coordinate notations.
4343 define( 'Maps_COORDS_FLOAT', 'float' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72432Changes for 0.4 - moving over parameter validation functionalityjeroendedauw14:29, 5 September 2010

Status & tagging log