r72413 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72412‎ | r72413 | r72414 >
Date:10:38, 5 September 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Apparently $ doesn't work without resourceloader - use jQuery
Modified paths:
  • /trunk/extensions/Translate/TranslatePage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslatePage.php
@@ -491,7 +491,7 @@
492492
493493 if ( $hasSubblocks ) {
494494 $msg = wfMsgExt( 'translate-showsub', 'parsemag', $wgLang->formatNum( count( $blocks ) ) );
495 - $desc .= Html::element( 'a', array( 'onclick' => "$('#$subid').toggle()", 'class' => 'mw-sp-showmore' ), $msg );
 495+ $desc .= Html::element( 'a', array( 'onclick' => "jQuery('#$subid').toggle()", 'class' => 'mw-sp-showmore' ), $msg );
496496 }
497497
498498 $out = "\n<tr><td>$label</td>\n<td>$desc</td></tr>\n";

Status & tagging log