r72402 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72401‎ | r72402 | r72403 >
Date:09:09, 5 September 2010
Author:dale
Status:deferred
Tags:
Comment:
added a delay to loading mwEmbed to give the edit toolbar a chance to build out
Modified paths:
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/kskin/mw.style.PlayerSkinKskin.css (modified) (history)
  • /branches/MwEmbedStandAlone/remotes/AddMediaWizardEditPage.js (modified) (history)
  • /branches/MwEmbedStandAlone/remotes/mediaWiki.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/kskin/mw.style.PlayerSkinKskin.css
@@ -336,6 +336,7 @@
337337 .k-player .menu-screen {
338338 height: 100%;
339339 overflow-y: auto;
 340+ overflow-x: hide;
340341 }
341342
342343
Index: branches/MwEmbedStandAlone/remotes/AddMediaWizardEditPage.js
@@ -89,6 +89,6 @@
9090 } );
9191 }
9292 }
93 - }, 200 )
 93+ }, 100 )
9494
9595 } );
Index: branches/MwEmbedStandAlone/remotes/mediaWiki.js
@@ -36,7 +36,6 @@
3737 }
3838
3939
40 -
4140 // Setup up some globals to wrap mwEmbed mw.ready and mw.setConfig functions
4241
4342 //Setup preMwEmbedReady queue
@@ -71,9 +70,11 @@
7271 * Wikimedia specific config
7372 ********************************/
7473 mw.setConfig( 'Sequencer.KalturaPlayerEditOverlay', true );
 74+mw.setConfig( 'EmbedPlayer.KalturaAttribution', true );
7575 mw.setConfig( 'SwarmTransport.Enable', true );
7676 mw.setConfig( 'SmilPlayer.AssetDomainWhiteList', ['upload.wikimedia.org'] );
7777
 78+
7879 // Use wikibits onLoad hook: ( since we don't have js2 / mw object loaded )
7980 addOnloadHook( function() {
8081 doPageSpecificRewrite();
@@ -93,18 +94,20 @@
9495 // Add media wizard ( only if not on a sequence page
9596 if ( wgAction == 'edit' || wgAction == 'submit' ) {
9697 if( wgPageName.indexOf( "Sequence:" ) != 0 ){
97 - loadMwEmbed( [
98 - 'mw.RemoteSearchDriver',
99 - 'mw.ClipEdit',
100 - 'mw.style.ClipEdit',
101 - '$j.fn.textSelection',
102 - '$j.ui',
103 - '$j.widget',
104 - '$j.ui.mouse',
105 - '$j.ui.sortable'
106 - ], function() {
107 - mw.load( mwEmbedHostPath + '/remotes/AddMediaWizardEditPage.js?' + mwGetReqArgs() );
108 - } );
 98+ setTimeout(function(){
 99+ loadMwEmbed( [
 100+ 'mw.RemoteSearchDriver',
 101+ 'mw.ClipEdit',
 102+ 'mw.style.ClipEdit',
 103+ '$j.fn.textSelection',
 104+ '$j.ui',
 105+ '$j.widget',
 106+ '$j.ui.mouse',
 107+ '$j.ui.sortable'
 108+ ], function() {
 109+ mw.load( mwEmbedHostPath + '/remotes/AddMediaWizardEditPage.js?' + mwGetReqArgs() );
 110+ } );
 111+ },100);
109112 return ;
110113 }
111114 }
@@ -565,7 +568,7 @@
566569 ||
567570 // force load jquery if version 1.3.2 ( issues with '1.3.2' .data handling )
568571 jQuery.fn.jquery == '1.3.2')
569 - {
 572+ {
570573 rurl += 'window.jQuery';
571574 coma = ',';
572575 }

Status & tagging log