r72381 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72380‎ | r72381 | r72382 >
Date:15:08, 4 September 2010
Author:ialex
Status:ok
Tags:
Comment:
Fixed some doxygen warnings
Modified paths:
  • /trunk/phase3/includes/job/UploadFromUrlJob.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadBase.php
@@ -298,7 +298,7 @@
299299
300300 /**
301301 * Verify the mime type
302 - * @param $magic MagicMime object
 302+ *
303303 * @param $mime string representing the mime
304304 * @return mixed true if the file is verified, an array otherwise
305305 */
Index: trunk/phase3/includes/job/UploadFromUrlJob.php
@@ -126,9 +126,9 @@
127127 * Store a result in the session data
128128 * THIS IS BROKEN. $_SESSION does not exist when using runJobs.php
129129 *
130 - * @param $result string The result (Success|Warning|Failure)
131 - * @param $dataKey string The key of the extra data
132 - * @param $dataKey mixed The extra data itself
 130+ * @param $result String: the result (Success|Warning|Failure)
 131+ * @param $dataKey String: the key of the extra data
 132+ * @param $dataValue Mixed: the extra data itself
133133 */
134134 protected function storeResultInSession( $result, $dataKey, $dataValue ) {
135135 $session &= $_SESSION[UploadBase::getSessionKeyname()][$this->params['sessionKey']];

Status & tagging log