r72330 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r72329‎ | r72330 | r72331 >
Date:22:58, 3 September 2010
Author:dale
Status:deferred
Tags:
Comment:
updated AMW to work with jquery ui 1.8
Modified paths:
  • /branches/MwEmbedStandAlone/modules/AddMedia/loader.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/AddMedia/mw.RemoteSearchDriver.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/AjaxCategories/mw.AjaxCategories.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/kskin/mw.style.PlayerSkinKskin.css (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/loader.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/TimedText/loader.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/UploadWizard/loader.js (modified) (history)
  • /branches/MwEmbedStandAlone/mwEmbed.js (modified) (history)
  • /branches/MwEmbedStandAlone/remotes/AddMediaWizardEditPage.js (modified) (history)
  • /branches/MwEmbedStandAlone/remotes/mediaWiki.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/mwEmbed.js
——@@ -1124,7 +1124,8 @@
11251125 mw.load([
11261126 [
11271127 '$j.ui',
1128 - '$j.widget'
 1128+ '$j.widget',
 1129+ '$j.ui.position'
11291130 ],
11301131 uiRequest
11311132 ], function() {
Index: branches/MwEmbedStandAlone/modules/UploadWizard/loader.js
——@@ -61,6 +61,8 @@
6262 var libraries = [
6363 [
6464 '$j.ui',
 65+ '$j.widget',
 66+ '$j.ui.position',
6567 '$j.ui.progressbar',
6668 '$j.ui.dialog',
6769 '$j.ui.draggable',
Index: branches/MwEmbedStandAlone/modules/TimedText/loader.js
——@@ -82,6 +82,7 @@
8383 [
8484 '$j.ui',
8585 '$j.widget',
 86+ '$j.ui.position',
8687 '$j.fn.menu',
8788 "mw.style.jquerymenu",
8889
Index: branches/MwEmbedStandAlone/modules/AddMedia/loader.js
——@@ -60,6 +60,8 @@
6161 ], [
6262 '$j.ui.resizable',
6363 '$j.ui.mouse',
 64+ '$j.widget',
 65+ '$j.ui.position',
6466 '$j.ui.draggable',
6567 '$j.ui.dialog',
6668 '$j.ui.tabs',
——@@ -72,12 +74,14 @@
7375 [
7476 'mw.UploadHandler',
7577 'mw.UploadInterface',
76 - '$j.ui'
 78+ '$j.ui',
 79+ '$j.widget'
7780 ],
7881 [
7982 '$j.ui.progressbar',
 83+ '$j.ui.position',
 84+ '$j.ui.mouse',
8085 '$j.ui.dialog',
81 - '$j.ui.mouse',
8286 '$j.ui.draggable'
8387 ]
8488 ];
Index: branches/MwEmbedStandAlone/modules/AddMedia/mw.RemoteSearchDriver.js
——@@ -850,14 +850,8 @@
851851 .attr({
852852 'id' : 'rsd_modal_target',
853853 'title' : gM( 'mwe-add_media_wizard' )
854 - })
855 - .css( {
856 - 'position' : 'absolute',
857 - 'top' : '3em',
858 - 'left' : '0px',
859 - 'bottom' : '3em',
860 - 'right' : '0px'
861 - })
 854+ })
 855+ .css("position", 'relative')
862856 );
863857 // Get layout
864858 mw.log( 'width: ' + $j( window ).width() + ' height: ' + $j( window ).height() );
——@@ -872,6 +866,9 @@
873867 bgiframe: true,
874868 autoOpen: true,
875869 modal: true,
 870+ width: $j(window).width()-10,
 871+ height: $j(window).height()-10,
 872+ position : 'center',
876873 draggable: false,
877874 resizable: false,
878875 buttons: cancelButton,
——@@ -882,7 +879,7 @@
883880 $j( this ).parents( '.ui-dialog' ).fadeOut( 'slow' );
884881 }
885882 } );
886 - $j( _this.target_container ).dialogFitWindow();
 883+ //$j( _this.target_container ).dialogFitWindow();
887884
888885 // Add the window resize hook to keep dialog layout
889886 $j( window ).resize( function() {
Index: branches/MwEmbedStandAlone/modules/AjaxCategories/mw.AjaxCategories.js
——@@ -110,6 +110,7 @@
111111 [
112112 '$j.ui',
113113 '$j.widget',
 114+ '$j.ui.position',
114115 '$j.ui.dialog',
115116 '$j.fn.suggestions'
116117 ],
——@@ -167,7 +168,7 @@
168169 confirmEdit : function( page, fn, actionSummary, doneFn ) {
169170 // Load jQuery UI
170171 mw.load(
171 - ['$j.ui', '$j.ui.dialog', '$j.fn.suggestions'],
 172+ ['$j.ui', '$j.ui.position', '$j.ui.dialog', '$j.fn.suggestions'],
172173 function() {
173174 // Produce a confirmation dialog
174175
Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/kskin/mw.style.PlayerSkinKskin.css
——@@ -167,6 +167,7 @@
168168 float: left;
169169 font-size: 11px;
170170 padding: 13px 10px 15px 15px;
 171+ overflow-y:scroll;
171172 }
172173
173174 .k-player ul.k-menu-bar {
Index: branches/MwEmbedStandAlone/modules/Sequencer/loader.js
——@@ -89,6 +89,7 @@
9090 // UI components used in the sequencer interface:
9191 '$j.ui.mouse',
9292 '$j.widget',
 93+ '$j.ui.position',
9394 '$j.ui.accordion',
9495 '$j.ui.dialog',
9596 '$j.ui.droppable',
Index: branches/MwEmbedStandAlone/remotes/AddMediaWizardEditPage.js
——@@ -88,6 +88,6 @@
8989 } );
9090 }
9191 }
92 - }, 120 )
 92+ }, 100 )
9393
9494 } );
Index: branches/MwEmbedStandAlone/remotes/mediaWiki.js
——@@ -67,9 +67,6 @@
6868 }
6969
7070
71 -
72 -
73 -
7471 /*******************************
7572 * Wikimedia specific config
7673 ********************************/
——@@ -77,13 +74,6 @@
7875 mw.setConfig( 'SwarmTransport.Enable', true );
7976 mw.setConfig( 'SmilPlayer.AssetDomainWhiteList', ['upload.wikimedia.org'] );
8077
81 -
82 -
83 -
84 -
85 -
86 -
87 -
8878 // Use wikibits onLoad hook: ( since we don't have js2 / mw object loaded )
8979 addOnloadHook( function() {
9080 doPageSpecificRewrite();
——@@ -190,6 +180,8 @@
191181 'mw.UploadInterface',
192182 'mw.Firefogg',
193183 '$j.ui',
 184+ '$j.widget',
 185+ '$j.ui.position',
194186 '$j.ui.progressbar',
195187 '$j.ui.dialog',
196188 '$j.ui.draggable'

Status & tagging log