r72258 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72257‎ | r72258 | r72259 >
Date:03:02, 3 September 2010
Author:tparscal
Status:ok
Tags:
Comment:
Added stub test files. Renamed ResourceLoaderSiteJsModule to ResourceLoaderSiteModule, and ResourceLoaderStartupModule to ResourceLoaderStartUpModule
Modified paths:
  • /branches/resourceloader/phase3/includes/AutoLoader.php (modified) (history)
  • /branches/resourceloader/phase3/includes/ResourceLoaderModule.php (modified) (history)
  • /branches/resourceloader/phase3/maintenance/tests/ResourceLoaderFileModuleTest.php (added) (history)
  • /branches/resourceloader/phase3/maintenance/tests/ResourceLoaderTest.php (added) (history)
  • /branches/resourceloader/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/maintenance/tests/ResourceLoaderTest.php
@@ -0,0 +1,16 @@
 2+<?php
 3+
 4+class ResourceLoaderTest extends PHPUnit_Framework_TestCase {
 5+
 6+ /* Provider Methods */
 7+
 8+ public function provide() {
 9+
 10+ }
 11+
 12+ /* Test Methods */
 13+
 14+ public function test() {
 15+
 16+ }
 17+}
\ No newline at end of file
Property changes on: branches/resourceloader/phase3/maintenance/tests/ResourceLoaderTest.php
___________________________________________________________________
Added: svn:eol-style
118 + native
Index: branches/resourceloader/phase3/maintenance/tests/ResourceLoaderFileModuleTest.php
@@ -0,0 +1,16 @@
 2+<?php
 3+
 4+class ResourceLoaderFileModuleTest extends PHPUnit_Framework_TestCase {
 5+
 6+ /* Provider Methods */
 7+
 8+ public function provide() {
 9+
 10+ }
 11+
 12+ /* Test Methods */
 13+
 14+ public function test() {
 15+
 16+ }
 17+}
\ No newline at end of file
Property changes on: branches/resourceloader/phase3/maintenance/tests/ResourceLoaderFileModuleTest.php
___________________________________________________________________
Added: svn:eol-style
118 + native
Index: branches/resourceloader/phase3/includes/AutoLoader.php
@@ -200,7 +200,8 @@
201201 'ResourceLoader' => 'includes/ResourceLoader.php',
202202 'ResourceLoaderFileModule' => 'includes/ResourceLoaderModule.php',
203203 'ResourceLoaderModule' => 'includes/ResourceLoaderModule.php',
204 - 'ResourceLoaderSiteJSModule' => 'includes/ResourceLoaderModule.php',
 204+ 'ResourceLoaderSiteModule' => 'includes/ResourceLoaderModule.php',
 205+ 'ResourceLoaderStartUpModule' => 'includes/ResourceLoaderModule.php',
205206 'ReverseChronologicalPager' => 'includes/Pager.php',
206207 'Revision' => 'includes/Revision.php',
207208 'RevisionDelete' => 'includes/RevisionDelete.php',
Index: branches/resourceloader/phase3/includes/ResourceLoaderModule.php
@@ -549,8 +549,9 @@
550550
551551 /**
552552 * Custom module for MediaWiki:Common.js and MediaWiki:Skinname.js
 553+ * TODO: Add Site CSS functionality too
553554 */
554 -class ResourceLoaderSiteJSModule extends ResourceLoaderModule {
 555+class ResourceLoaderSiteModule extends ResourceLoaderModule {
555556 // In-object cache for modified time
556557 private $modifiedTime = null;
557558
@@ -591,7 +592,7 @@
592593 }
593594
594595
595 -class ResourceLoaderStartupModule extends ResourceLoaderModule {
 596+class ResourceLoaderStartUpModule extends ResourceLoaderModule {
596597 private $modifiedTime = null;
597598
598599 public function getScript( $lang, $skin, $debug ) {
Index: branches/resourceloader/phase3/resources/Resources.php
@@ -4,8 +4,8 @@
55
66 /* Special resources who have their own classes */
77
8 - 'sitejs' => new ResourceLoaderSiteJSModule,
9 - 'startup' => new ResourceLoaderStartupModule,
 8+ 'site' => new ResourceLoaderSiteModule,
 9+ 'startup' => new ResourceLoaderStartUpModule,
1010
1111 /* Skins */
1212

Follow-up revisions

RevisionCommit summaryAuthorDate
r90187Another stub test file...this one has been like this since r72258demon23:24, 15 June 2011

Status & tagging log