r72231 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72230‎ | r72231 | r72232 >
Date:21:25, 2 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
removing htmlspecialchars() per comment at r72177
Modified paths:
  • /trunk/extensions/CentralNotice/BannerLoader.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/BannerLoader.php
@@ -28,7 +28,7 @@
2929 $this->project = $wgRequest->getText( 'project', 'wikipedia' );
3030
3131 if ( $wgRequest->getText( 'banner' ) ) {
32 - $bannerName = htmlspecialchars( $wgRequest->getText( 'banner' ) );
 32+ $bannerName = $wgRequest->getText( 'banner' );
3333 $content = $this->getHtmlNotice( $bannerName );
3434 if ( strlen( $content ) == 0 ) {
3535 // Hack for IE/Mac 0-length keepalive problem, see RawPage.php

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72177initial version of BannerLoaderkaldari23:18, 1 September 2010

Status & tagging log