r72171 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72170‎ | r72171 | r72172 >
Date:22:37, 1 September 2010
Author:leonsp
Status:ok
Tags:
Comment:
Reverting some of r72166 and fixing the $wgDBport collision between Postgres and DB2 in a different way.
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
@@ -644,6 +644,7 @@
645645 $conf->SQLiteDataDir = importPost( "SQLiteDataDir", "$IP/../data" );
646646
647647 ## DB2 specific:
 648+ $conf->DBport_db2 = importPost( "DBport_db2", "50000" );
648649 $conf->DBdb2schema = importPost( "DBdb2schema", "mediawiki" );
649650
650651 // Oracle specific
@@ -834,6 +835,9 @@
835836 }
836837
837838 ## DB2 specific:
 839+ if ( $conf->DBtype == 'ibm_db2' ) {
 840+ $wgDBport = $conf->DBport_db2;
 841+ }
838842
839843 $wgCommandLineMode = true;
840844 if (! defined ( 'STDERR' ) )
@@ -1707,7 +1711,7 @@
17081712
17091713 <?php database_switcher($ourdb, 'ibm_db2'); ?>
17101714 <div class="config-input"><?php
1711 - aField( $conf, "DBport", "Database port:" );
 1715+ aField( $conf, "DBport_db2", "Database port:" );
17121716 ?></div>
17131717 <div class="config-desc">
17141718 <p>50000 is the usual DB2 port.</p>
@@ -1905,10 +1909,11 @@
19061910 "# SQLite-specific settings
19071911 \$wgSQLiteDataDir = \"{$sqliteDataDir}\";";
19081912 } elseif( $conf->DBtype == 'ibm_db2' ) {
1909 - $dbsettings =
1910 -"# DB2 specific settings
1911 -\$wgDBport = \"{$slconf['DBport']}\";
1912 -\$wgDBmwschema = \"{$slconf['DBdb2schema']}\";";
 1913+ $dbsettings = <<<MULTILINE
 1914+# DB2 specific settings
 1915+\$wgDBport = "{$slconf['DBport_db2']}";
 1916+\$wgDBmwschema = "{$slconf['DBdb2schema']}";
 1917+MULTILINE;
19131918 } elseif( $conf->DBtype == 'oracle' ) {
19141919 $dbsettings =
19151920 "# Oracle specific settings

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72166Completed removal of $wgDBport_db2 in favour of regular $wgDBport begun by pl...leonsp21:06, 1 September 2010

Status & tagging log