r72148 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72147‎ | r72148 | r72149 >
Date:18:52, 1 September 2010
Author:tparscal
Status:resolved
Tags:
Comment:
Integrated shared and commonPrint modules
Modified paths:
  • /branches/resourceloader/phase3/includes/Skin.php (modified) (history)
  • /branches/resourceloader/phase3/includes/SkinTemplate.php (modified) (history)
  • /branches/resourceloader/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/includes/SkinTemplate.php
@@ -107,8 +107,8 @@
108108 * @param $out OutputPage
109109 */
110110 function setupSkinUserCss( OutputPage $out ){
111 - $out->addStyle( 'common/shared.css', 'screen' );
112 - $out->addStyle( 'common/commonPrint.css', 'print' );
 111+ $out->addModuleStyles( 'mediawiki.legacy.shared' );
 112+ $out->addModuleStyles( 'mediawiki.legacy.commonPrint' );
113113 }
114114
115115 /**
Index: branches/resourceloader/phase3/includes/Skin.php
@@ -680,8 +680,9 @@
681681 * @param $out OutputPage
682682 */
683683 function setupSkinUserCss( OutputPage $out ) {
684 - $out->addStyle( 'common/shared.css' );
685 - $out->addStyle( 'common/oldshared.css' );
 684+ // This includes the shared.js and oldshared.js files from skins/common/
 685+ $out->addModuleStyles( 'mediawiki.legacy.shared' );
 686+ // TODO: Figure out how to best integrate this stuff into ResourceLoader
686687 $out->addStyle( $this->getStylesheet() );
687688 $out->addStyle( 'common/common_rtl.css', '', '', 'rtl' );
688689 }
Index: branches/resourceloader/phase3/resources/Resources.php
@@ -291,6 +291,9 @@
292292 'scripts' => 'skins/common/enhancedchanges.js',
293293 'dependencies' => 'mediawiki',
294294 ) ),
 295+ 'mediawiki.legacy.commonPrint' => new ResourceLoaderFileModule( array(
 296+ 'scripts' => 'skins/common/commonPrint.css',
 297+ ) ),
295298 'mediawiki.legacy.config' => new ResourceLoaderFileModule( array(
296299 'scripts' => 'skins/common/config.js',
297300 'styles' => array( 'skins/common/config.css', 'skins/common/config-cc.css' ),
@@ -346,6 +349,10 @@
347350 'scripts' => 'skins/common/search.js',
348351 'dependencies' => 'mediawiki',
349352 ) ),
 353+ 'mediawiki.legacy.shared' => new ResourceLoaderFileModule( array(
 354+ 'scripts' => 'skins/common/shared.css',
 355+ 'scripts' => 'skins/common/oldshared.css',
 356+ ) ),
350357 'mediawiki.legacy.upload' => new ResourceLoaderFileModule( array(
351358 'scripts' => 'skins/common/upload.js',
352359 'dependencies' => 'mediawiki',

Status & tagging log