| Index: trunk/phase3/includes/installer/DatabaseInstaller.php |
| — | — | @@ -80,7 +80,9 @@ |
| 81 | 81 | * If the DB type has no settings beyond those already configured with |
| 82 | 82 | * getConnectForm(), this should return false. |
| 83 | 83 | */ |
| 84 | | - public abstract function getSettingsForm(); |
| | 84 | + public function getSettingsForm() { |
| | 85 | + return false; |
| | 86 | + } |
| 85 | 87 | |
| 86 | 88 | /** |
| 87 | 89 | * Set variables based on the request array, assuming it was submitted via |
| — | — | @@ -88,7 +90,9 @@ |
| 89 | 91 | * |
| 90 | 92 | * @return Status |
| 91 | 93 | */ |
| 92 | | - public abstract function submitSettingsForm(); |
| | 94 | + public function submitSettingsForm() { |
| | 95 | + return Status::newGood(); |
| | 96 | + } |
| 93 | 97 | |
| 94 | 98 | /** |
| 95 | 99 | * Connect to the database using the administrative user/password currently |
| Index: trunk/phase3/includes/installer/OracleInstaller.php |
| — | — | @@ -88,15 +88,6 @@ |
| 89 | 89 | return $status; |
| 90 | 90 | } |
| 91 | 91 | |
| 92 | | - |
| 93 | | - public function getSettingsForm() { |
| 94 | | - // TODO |
| 95 | | - } |
| 96 | | - |
| 97 | | - public function submitSettingsForm() { |
| 98 | | - // TODO |
| 99 | | - } |
| 100 | | - |
| 101 | 92 | public function getConnection() { |
| 102 | 93 | // TODO |
| 103 | 94 | } |
| Index: trunk/phase3/includes/installer/PostgresInstaller.php |
| — | — | @@ -112,14 +112,6 @@ |
| 113 | 113 | return $status; |
| 114 | 114 | } |
| 115 | 115 | |
| 116 | | - function getSettingsForm() { |
| 117 | | - return false; |
| 118 | | - } |
| 119 | | - |
| 120 | | - function submitSettingsForm() { |
| 121 | | - return Status::newGood(); |
| 122 | | - } |
| 123 | | - |
| 124 | 116 | function setupDatabase() { |
| 125 | 117 | } |
| 126 | 118 | |
| Index: trunk/phase3/includes/installer/SqliteInstaller.php |
| — | — | @@ -122,14 +122,6 @@ |
| 123 | 123 | return parent::needsUpgrade(); |
| 124 | 124 | } |
| 125 | 125 | |
| 126 | | - public function getSettingsForm() { |
| 127 | | - return false; |
| 128 | | - } |
| 129 | | - |
| 130 | | - public function submitSettingsForm() { |
| 131 | | - return Status::newGood(); |
| 132 | | - } |
| 133 | | - |
| 134 | 126 | public function setupDatabase() { |
| 135 | 127 | $dir = $this->getVar( 'wgSQLiteDataDir' ); |
| 136 | 128 | |