r72050 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72049‎ | r72050 | r72051 >
Date:21:03, 31 August 2010
Author:tparscal
Status:ok
Tags:
Comment:
renamed getmtime to getModifiedTime
Modified paths:
  • /branches/resourceloader/phase3/includes/ResourceLoader.php (modified) (history)
  • /branches/resourceloader/phase3/includes/ResourceLoaderModule.php (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/includes/ResourceLoader.php
@@ -259,7 +259,7 @@
260260 // Calculate the mtime of this request. We need this, 304 or no 304
261261 $mtime = 1;
262262 foreach ( $modules as $name ) {
263 - $mtime = max( $mtime, self::getModule( $name )->getmtime(
 263+ $mtime = max( $mtime, self::getModule( $name )->getModifiedTime(
264264 $parameters['lang'], $parameters['skin'], $parameters['debug']
265265 ) );
266266 }
Index: branches/resourceloader/phase3/includes/ResourceLoaderModule.php
@@ -101,7 +101,7 @@
102102 * @param $debug bool Debug mode flag
103103 * @return int UNIX timestamp
104104 */
105 - public abstract function getmtime( $lang, $skin, $debug );
 105+ public abstract function getModifiedTime( $lang, $skin, $debug );
106106 }
107107
108108 /**
@@ -334,7 +334,7 @@
335335 * @param $debug bool Debug mode flag
336336 * @return int UNIX timestamp
337337 */
338 - public function getmtime( $lang, $skin, $debug ) {
 338+ public function getModifiedTime( $lang, $skin, $debug ) {
339339 $files = array_merge( $this->scripts, $this->styles,
340340 $debug ? $this->debugScripts : array(),
341341 isset( $this->languageScripts[$lang] ) ? (array)$this->languageScripts[$lang] : array(),
@@ -474,7 +474,7 @@
475475 return Skin::newFromKey( $skin )->generateUserJs();
476476 }
477477
478 - public function getmtime( $lang, $skin, $debug ) {
 478+ public function getModifiedTime( $lang, $skin, $debug ) {
479479 // HACK: We duplicate the message names from generateUserJs()
480480 // here and weird things (i.e. mtime moving backwards) can happen
481481 // when a MediaWiki:Something.js page is deleted

Status & tagging log