r72020 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72019‎ | r72020 | r72021 >
Date:11:01, 31 August 2010
Author:hartman
Status:ok
Tags:
Comment:
Followup r71942. Documentation fix, the mime passed is a string, not an object.
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -1684,9 +1684,9 @@
16851685 'UploadVerifyFile': extra file verification, based on mime type, etc. Preferred
16861686 in most cases over UploadVerification.
16871687 object $upload: an instance of UploadBase, with all info about the upload
1688 -object $mime: the uploaded file's mime type, as detected by MediaWiki. Handlers
 1688+string $mime: the uploaded file's mime type, as detected by MediaWiki. Handlers
16891689 will typically only apply for specific mime types.
1690 -object &$error: output: true if the file is valid. Otherwise, and indexed array
 1690+object &$error: output: true if the file is valid. Otherwise, an indexed array
16911691 representing the problem with the file, where the first element
16921692 is the message key and the remaining elements are used as parameters to
16931693 the message.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71942interoduced new hoop in Uploadbase::verifyFile, as per comments to r71789daniel12:10, 30 August 2010

Status & tagging log