r71829 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71828‎ | r71829 | r71830 >
Date:00:24, 28 August 2010
Author:kaldari
Status:ok
Tags:
Comment:
forgot to update calls to updatePreferred in r71828
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialCentralNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialCentralNotice.php
@@ -114,7 +114,7 @@
115115 // Set since this is a single display
116116 if ( $method == 'listNoticeDetail' ) {
117117 $notice = $wgRequest->getVal ( 'notice' );
118 - $this->centralNoticeDB->updatePreferred( $notice, '1' );
 118+ $this->updatePreferred( $notice, '1' );
119119 }
120120 else {
121121 // Build list of campaigns to unset
@@ -122,10 +122,10 @@
123123
124124 // Set flag accordingly
125125 foreach ( $preferredNotices as $notice ) {
126 - $this->centralNoticeDB->updatePreferred( $notice, '1' );
 126+ $this->updatePreferred( $notice, '1' );
127127 }
128128 foreach ( $unsetNotices as $notice ) {
129 - $this->centralNoticeDB->updatePreferred( $notice, '0' );
 129+ $this->updatePreferred( $notice, '0' );
130130 }
131131 }
132132 }
@@ -177,11 +177,11 @@
178178 if ( !isset( $preferredNotices ) && $method !== 'addNotice' ) {
179179 if ( $method == 'listNoticeDetail' ) {
180180 $notice = $wgRequest->getVal ( 'notice' );
181 - $this->centralNoticeDB->updatePreferred( $notice, 0 );
 181+ $this->updatePreferred( $notice, 0 );
182182 } else {
183183 $allNotices = $this->getNoticesName();
184184 foreach ( $allNotices as $notice ) {
185 - $this->centralNoticeDB->updatePreferred( $notice, '0' );
 185+ $this->updatePreferred( $notice, '0' );
186186 }
187187 }
188188 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71828adding noticeExists() test, moving updatePreferred(), removing unneccessary t...kaldari00:15, 28 August 2010

Status & tagging log