r71804 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71803‎ | r71804 | r71805 >
Date:20:54, 27 August 2010
Author:siebrand
Status:deferred
Tags:
Comment:
* Use TranslateEditAddons::figureMessage() instead of Title::getBaseText to not fail on keys with spaces
* Remove superfluous space after field name because buildLike() adds a leading space.
Modified paths:
  • /trunk/extensions/Translate/utils/MessageWebImporter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/MessageWebImporter.php
@@ -348,13 +348,14 @@
349349 $dbw = wfGetDB( DB_MASTER );
350350
351351 // Work on all subpages of base title.
352 - $titleText = $title->getBaseText();
 352+ $messageInfo = TranslateEditAddons::figureMessage( $title );
 353+ $titleText = $messageInfo[0];
353354
354355 $conds = array(
355356 'page_namespace' => $title->getNamespace(),
356357 'page_latest=rev_id',
357358 'rev_text_id=old_id',
358 - 'page_title ' . $dbw->buildLike( "$titleText/", $dbw->anyString() ),
 359+ 'page_title' . $dbw->buildLike( "$titleText/", $dbw->anyString() ),
359360 );
360361
361362 $rows = $dbw->select(

Status & tagging log