r71768 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r71767‎ \| r71768 \| r71769 >
Date:	23:37, 26 August 2010
Author:	tparscal
Status:	ok
Tags:
Comment:	Added /* @embed */ comments to embed all images. Huge savings, even for the sprited images.
Modified paths:	/branches/resourceloader/phase3/skins/vector/main-ltr.css (modified) (history) /branches/resourceloader/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/skins/vector/main-ltr.css
—	—	@@ -537,7 +537,7 @@
538	538	clear: both;
539	539	margin: 0 !important;
540	540	padding: 0 !important;
541		~~- /* @embed */~~
	541	+ /* @embed */
542	542	background-image: url(images/preferences-break.png?1);
543	543	background-position: bottom left;
544	544	background-repeat: no-repeat;
—	—	@@ -1150,20 +1150,24 @@
1151	1151	overflow: hidden;
1152	1152	}
1153	1153	#ca-unwatch.icon a {
	1154	+ /* @embed */
1154	1155	background-image: url(images/watch-icons.png?1);
1155	1156	background-position: -43px 60%;
1156	1157	}
1157	1158	#ca-watch.icon a {
	1159	+ /* @embed */
1158	1160	background-image: url(images/watch-icons.png?1);
1159	1161	background-position: 5px 60%;
1160	1162	}
1161	1163	#ca-unwatch.icon a:hover,
1162	1164	#ca-unwatch.icon a:focus {
	1165	+ /* @embed */
1163	1166	background-image: url(images/watch-icons.png?1);
1164	1167	background-position: -67px 60%;
1165	1168	}
1166	1169	#ca-watch.icon a:hover,
1167	1170	#ca-watch.icon a:focus {
	1171	+ /* @embed */
1168	1172	background-image: url(images/watch-icons.png?1);
1169	1173	background-position: -19px 60%;
1170	1174	}
Index: branches/resourceloader/phase3/skins/vector/main-rtl.css
—	—	@@ -25,24 +25,26 @@
26	26	}
27	27	body {
28	28	background-color: #f3f3f3;
	29	+ /* @embed */
29	30	background-image: url(images/page-base.png?1);
30	31	}
31	32	/* Content */
32	33	div#content {
33	34	margin-right: 10em;
34	35	padding: 1em;
	36	+ /* @embed */
35	37	background-image: url(images/border.png?1);
36	38	background-position: top right;
37	39	background-repeat: repeat-y;
38	40	background-color: white;
39	41	color: black;
40		~~- direction: rtl;~~
41	42	}
42	43	/* Head */
43	44	#mw-page-base {
44	45	height: 5em;
45	46	background-color: white;
46		~~- background-image: url(images/page-fade.png?1);~~
	47	+ /* @embed */
	48	+ background-image: url("images/page-fade.png?1");
47	49	background-position: bottom right;
48	50	background-repeat: repeat-x;
49	51	}
—	—	@@ -50,7 +52,8 @@
51	53	margin-top: -5em;
52	54	margin-right: 10em;
53	55	height: 5em;
54		~~- background-image: url(images/border.png?1);~~
	56	+ /* @embed */
	57	+ background-image: url('images/border.png?1');
55	58	background-position: bottom right;
56	59	background-repeat: repeat-x;
57	60	}
—	—	@@ -117,6 +120,7 @@
118	121	height: 2.5em;
119	122	}
120	123	div.vectorTabs {
	124	+ /* @embed */
121	125	background-image: url(images/tab-break.png?1);
122	126	background-position: bottom right;
123	127	background-repeat: no-repeat;
—	—	@@ -144,6 +148,7 @@
145	149	margin: 0;
146	150	padding: 0;
147	151	background-color: #f3f3f3;
	152	+ /* @embed */
148	153	background-image: url(images/tab-normal-fade.png?1);
149	154	background-position: bottom right;
150	155	background-repeat: repeat-x;
—	—	@@ -154,6 +159,7 @@
155	160	display: block;
156	161	}
157	162	div.vectorTabs li.selected {
	163	+ /* @embed */
158	164	background-image: url(images/tab-current-fade.png?1);
159	165	}
160	166	/* OVERRIDDEN BY COMPLIANT BROWSERS */
—	—	@@ -162,6 +168,7 @@
163	169	height: 1.9em;
164	170	padding-right: 0.5em;
165	171	padding-left: 0.5em;
	172	+ /* @embed */
166	173	background-image: url(images/tab-break.png?1);
167	174	background-position: bottom left;
168	175	background-repeat: no-repeat;
—	—	@@ -202,6 +209,7 @@
203	210	div.vectorMenu {
204	211	direction: ltr;
205	212	float: left;
	213	+ /* @embed */
206	214	background-image: url(images/arrow-down-icon.png?1);
207	215	background-position: 100% 60%;
208	216	background-repeat: no-repeat;
—	—	@@ -215,6 +223,7 @@
216	224	/* @noflip */
217	225	div#mw-head div.vectorMenu h5 {
218	226	float: left;
	227	+ /* @embed */
219	228	background-image: url(images/tab-break.png?1);
220	229	background-repeat: no-repeat;
221	230	}
—	—	@@ -242,6 +251,7 @@
243	252	width: 24px;
244	253	height: 2.5em;
245	254	text-decoration: none;
	255	+ /* @embed */
246	256	background-image: url(images/tab-break.png?1);
247	257	background-repeat: no-repeat;
248	258	}
—	—	@@ -274,8 +284,7 @@
275	285	x:-moz-any-link {
276	286	margin-left: 23px;
277	287	}
278		~~- div.vectorMenu:hover div.menu,~~
279		~~- div.vectorMenu:focus div.menu {~~
	288	+ div.vectorMenu:hover div.menu {
280	289	display: block;
281	290	}
282	291	div.vectorMenu ul {
—	—	@@ -351,6 +360,7 @@
352	361	min-height: 1px; /* Gotta trigger hasLayout for IE7 */
353	362	border: solid 1px #AAAAAA;
354	363	background-color: white;
	364	+ /* @embed */
355	365	background-image: url(images/search-fade.png?1);
356	366	background-position: top right;
357	367	background-repeat: repeat-x;
—	—	@@ -407,7 +417,7 @@
408	418	}
409	419	div#mw-panel div.portal {
410	420	padding-bottom: 1.5em;
411		~~- direction: rtl;~~
	421	+ direction: ltr;
412	422	}
413	423	div#mw-panel div.portal h5 {
414	424	font-weight: normal;
—	—	@@ -423,6 +433,7 @@
424	434	margin: 0;
425	435	padding-top: 0.5em;
426	436	margin-right: 1.25em;
	437	+ /* @embed */
427	438	background-image: url(images/portal-break.png?1);
428	439	background-repeat: no-repeat;
429	440	background-position: top right;
—	—	@@ -453,10 +464,11 @@
454	465	margin-right: 10em;
455	466	margin-top: 0;
456	467	padding: 0.75em;
457		~~- background-image: url(images/border.png?1);~~
	468	+ /* @embed */
	469	+ background-image: url("images/border.png?1");
458	470	background-position: top right;
459	471	background-repeat: repeat-x;
460		~~- direction: rtl;~~
	472	+ direction: ltr;
461	473	}
462	474	div#footer ul {
463	475	list-style: none;
—	—	@@ -525,6 +537,7 @@
526	538	clear: both;
527	539	margin: 0 !important;
528	540	padding: 0 !important;
	541	+ /* @embed */
529	542	background-image: url(images/preferences-break.png?1);
530	543	background-position: bottom right;
531	544	background-repeat: no-repeat;
—	—	@@ -539,6 +552,7 @@
540	553	white-space: nowrap;
541	554	list-style-type: none;
542	555	list-style-image: none;
	556	+ /* @embed */
543	557	background-image: url(images/preferences-break.png?1);
544	558	background-position: bottom left;
545	559	background-repeat: no-repeat;
—	—	@@ -557,10 +571,12 @@
558	572	background-image: none;
559	573	font-size: 0.9em;
560	574	}
561		~~- #preftoc a:hover, #preftoc a:focus {~~
	575	+ #preftoc a:hover,
	576	+ #preftoc a:focus {
562	577	text-decoration: underline;
563	578	}
564	579	#preftoc li.selected a {
	580	+ /* @embed */
565	581	background-image: url(images/preferences-fade.png?1);
566	582	background-position: bottom;
567	583	background-repeat: repeat-x;
—	—	@@ -575,6 +591,7 @@
576	592	clear: both;
577	593	border: solid 1px #cccccc;
578	594	background-color: #f9f9f9;
	595	+ /* @embed */
579	596	background-image: url(images/preferences-base.png?1);
580	597	}
581	598	#preferences fieldset.prefsection {
—	—	@@ -755,6 +772,7 @@
756	773	list-style-type: square;
757	774	margin: .3em 1.5em 0 0;
758	775	padding: 0;
	776	+ /* @embed */
759	777	list-style-image: url(images/bullet-icon.png?1);
760	778	}
761	779	ol {
—	—	@@ -1012,31 +1030,37 @@
1013	1031	}
1014	1032	div#content a.external,
1015	1033	div#content a[href ^="gopher://"] {
	1034	+ /* @embed */
1016	1035	background: url(images/external-link-rtl-icon.png?2) center left no-repeat;
1017	1036	padding: 0 0 0 13px;
1018	1037	}
1019	1038	div#content a[href ^="https://"],
1020	1039	.link-https {
	1040	+ /* @embed */
1021	1041	background: url(images/lock-icon.png?2) center left no-repeat;
1022	1042	padding: 0 0 0 13px;
1023	1043	}
1024	1044	div#content a[href ^="mailto:"],
1025	1045	.link-mailto {
	1046	+ /* @embed */
1026	1047	background: url(images/mail-icon.png?2) center left no-repeat;
1027	1048	padding: 0 0 0 13px;
1028	1049	}
1029	1050	div#content a[href ^="news://"] {
	1051	+ /* @embed */
1030	1052	background: url(images/news-icon.png?2) center left no-repeat;
1031	1053	padding: 0 0 0 13px;
1032	1054	}
1033	1055	div#content a[href ^="ftp://"],
1034	1056	.link-ftp {
	1057	+ /* @embed */
1035	1058	background: url(images/file-icon.png?2) center left no-repeat;
1036	1059	padding: 0 0 0 13px;
1037	1060	}
1038	1061	div#content a[href ^="irc://"],
1039	1062	div#content a.extiw[href ^="irc://"],
1040	1063	.link-irc {
	1064	+ /* @embed */
1041	1065	background: url(images/talk-icon.png?2) center left no-repeat;
1042	1066	padding: 0 0 0 13px;
1043	1067	}
—	—	@@ -1047,6 +1071,7 @@
1048	1072	div#content a.external[href $=".wav"], div#content a.external[href $=".WAV"],
1049	1073	div#content a.external[href $=".wma"], div#content a.external[href $=".WMA"],
1050	1074	.link-audio {
	1075	+ /* @embed */
1051	1076	background: url("images/audio-icon.png?2") center left no-repeat;
1052	1077	padding: 0 0 0 13px;
1053	1078	}
—	—	@@ -1055,6 +1080,7 @@
1056	1081	div#content a.external[href $=".mpeg"], div#content a.external[href $=".MPEG"],
1057	1082	div#content a.external[href $=".mpg"], div#content a.external[href $=".MPG"],
1058	1083	.link-video {
	1084	+ /* @embed */
1059	1085	background: url("images/video-icon.png?2") center left no-repeat;
1060	1086	padding: 0 0 0 13px;
1061	1087	}
—	—	@@ -1062,6 +1088,7 @@
1063	1089	div#content a.external[href =".pdf#"], div#content a.external[href =".PDF#"],
1064	1090	div#content a.external[href =".pdf?"], div#content a.external[href =".PDF?"],
1065	1091	.link-document {
	1092	+ /* @embed */
1066	1093	background: url("images/document-icon.png?2") center left no-repeat;
1067	1094	padding: 0 0 0 13px;
1068	1095	}
—	—	@@ -1082,6 +1109,7 @@
1083	1110	#pt-userpage,
1084	1111	#pt-anonuserpage,
1085	1112	#pt-login {
	1113	+ /* @embed */
1086	1114	background: url(images/user-icon.png?1) right top no-repeat;
1087	1115	padding-right: 15px !important;
1088	1116	text-transform: none;
—	—	@@ -1122,25 +1150,30 @@
1123	1151	overflow: hidden;
1124	1152	}
1125	1153	#ca-unwatch.icon a {
	1154	+ /* @embed */
1126	1155	background-image: url(images/watch-icons.png?1);
1127	1156	background-position: -43px 60%;
1128	1157	}
1129	1158	#ca-watch.icon a {
	1159	+ /* @embed */
1130	1160	background-image: url(images/watch-icons.png?1);
1131	1161	background-position: 5px 60%;
1132	1162	}
1133	1163	#ca-unwatch.icon a:hover,
1134	1164	#ca-unwatch.icon a:focus {
	1165	+ /* @embed */
1135	1166	background-image: url(images/watch-icons.png?1);
1136	1167	background-position: -67px 60%;
1137	1168	}
1138	1169	#ca-watch.icon a:hover,
1139	1170	#ca-watch.icon a:focus {
	1171	+ /* @embed */
1140	1172	background-image: url(images/watch-icons.png?1);
1141	1173	background-position: -19px 60%;
1142	1174	}
1143	1175	#ca-unwatch.icon a.loading,
1144	1176	#ca-watch.icon a.loading {
	1177	+ /* @embed */
1145	1178	background-image: url(images/watch-icon-loading.gif?1);
1146	1179	background-position: center 60%;
1147	1180	}
—	—	@@ -1149,6 +1182,7 @@
1150	1183	display: none;
1151	1184	}
1152	1185	div.vectorTabs ul {
	1186	+ /* @embed */
1153	1187	background-image:url(images/tab-break.png?1);
1154	1188	background-position:left bottom;
1155	1189	background-repeat:no-repeat;
—	—	@@ -1158,4 +1192,4 @@
1159	1193	p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
1160	1194	p.mw-filedelete-editreasons, p.mw-delete-editreasons {
1161	1195	float: left;
1162		-}
\ No newline at end of file
	1196	+}

Status & tagging log

12:42, 27 September 2010 Catrope (talk | contribs) changed the status of r71768 [removed: new added: ok]