r71657 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71656‎ | r71657 | r71658 >
Date:20:04, 25 August 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Remove set/getType from MessageGroupOld - not really used
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)
  • /trunk/extensions/Translate/groups/MediaWikiExtensions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
@@ -85,10 +85,6 @@
8686
8787 public function setMangler( $value ) { $this->mangler = $value; }
8888
89 - protected $type = 'undefined';
90 - public function getType() { return $this->type; }
91 - public function setType( $value ) { $this->type = $value; }
92 -
9389 public $namespaces = array( NS_MEDIAWIKI, NS_MEDIAWIKI_TALK );
9490
9591 public function getReader( $code ) {
@@ -810,10 +806,6 @@
811807 return $this->title;
812808 }
813809
814 - public function getType() {
815 - return 'mediawiki';
816 - }
817 -
818810 public function getDefinitions() {
819811 $dbr = wfGetDB( DB_SLAVE );
820812 $tables = 'translate_sections';
Index: trunk/extensions/Translate/groups/MediaWikiExtensions.php
@@ -227,7 +227,6 @@
228228 if ( isset( $info['aliasvar'] ) ) $group->setVariableNameAlias( $info['aliasvar'] );
229229 if ( isset( $info['magicfile'] ) ) $group->setMagicFile( $info['magicfile'] );
230230
231 - $group->setType( 'mediawiki' );
232231 return $group;
233232 }
234233 }

Status & tagging log