r71638 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71637‎ | r71638 | r71639 >
Date:18:05, 25 August 2010
Author:tparscal
Status:ok
Tags:
Comment:
Removed remaining user parameter artifacts
Modified paths:
  • /branches/resourceloader/phase3/includes/ResourceLoader.php (modified) (history)
  • /branches/resourceloader/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/includes/ResourceLoader.php
@@ -164,7 +164,6 @@
165165 *
166166 * $options format:
167167 * array(
168 - * 'user' => [boolean: true for logged in, false for anon, optional, state of current user by default],
169168 * 'lang' => [string: language code, optional, code of default language by default],
170169 * 'skin' => [string: name of skin, optional, name of default skin by default],
171170 * 'dir' => [string: 'ltr' or 'rtl', optional, direction of lang by default],
@@ -176,14 +175,12 @@
177176 // Fallback on system settings
178177 // FIXME: Unnecessary unstubbing going on here, work around that
179178 $parameters = array(
180 - 'user' => $request->getVal( 'user', $wgUser->isLoggedIn() ),
181179 'lang' => $request->getVal( 'lang', $wgLang->getCode() ),
182180 'skin' => $request->getVal( 'skin', $wgDefaultSkin ),
183181 'debug' => $request->getVal( 'debug' ),
184182 );
185183 // Mediawiki's WebRequest::getBool is a bit on the annoying side - we need to allow 'true' and 'false' values
186184 // to be converted to boolean true and false
187 - $parameters['user'] = $parameters['user'] === 'true' || $parameters['user'];
188185 $parameters['debug'] = $parameters['debug'] === 'true' || $parameters['debug'];
189186 // Get the direction from the requested language
190187 if ( !isset( $parameters['dir'] ) ) {
Index: branches/resourceloader/phase3/resources/mediawiki/mediawiki.js
@@ -403,7 +403,6 @@
404404 batch.sort();
405405 // Build a list of request parameters
406406 var base = {
407 - 'user': mediaWiki.config.get( 'wgUserName' ) !== null,
408407 'skin': mediaWiki.config.get( 'skin' ),
409408 'lang': mediaWiki.config.get( 'wgUserLanguage' ),
410409 'debug': mediaWiki.config.get( 'debug' ),

Status & tagging log