r71633 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71632‎ | r71633 | r71634 >
Date:17:39, 25 August 2010
Author:kaldari
Status:ok
Tags:
Comment:
function declaration clean-up, see comment at r71608
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialCentralNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialCentralNotice.php
@@ -262,7 +262,7 @@
263263 $dbw->commit();
264264 }
265265
266 - static public function printHeader() {
 266+ public static function printHeader() {
267267 global $wgOut, $wgTitle, $wgUser;
268268 $sk = $wgUser->getSkin();
269269
@@ -1078,7 +1078,7 @@
10791079 /**
10801080 * Lookup the ID for a campaign based on the campaign name
10811081 */
1082 - public function getNoticeId( $noticeName ) {
 1082+ public static function getNoticeId( $noticeName ) {
10831083 $dbr = wfGetDB( DB_SLAVE );
10841084 $eNoticeName = htmlspecialchars( $noticeName );
10851085 $res = $dbr->select( 'cn_notices', 'not_id', array( 'not_name' => $eNoticeName ) );
@@ -1100,7 +1100,7 @@
11011101 return $languages;
11021102 }
11031103
1104 - function getNoticeProjectName ( $noticeName ) {
 1104+ function getNoticeProjectName( $noticeName ) {
11051105 $dbr = wfGetDB( DB_SLAVE );
11061106 $eNoticeName = htmlspecialchars( $noticeName );
11071107 $res = $dbr->select( 'cn_notices', 'not_project', array( 'not_name' => $eNoticeName ) );
@@ -1125,7 +1125,7 @@
11261126 $dbw->commit();
11271127 }
11281128
1129 - function updateNoticeDate ( $noticeName, $start, $end ) {
 1129+ function updateNoticeDate( $noticeName, $start, $end ) {
11301130 global $wgOut;
11311131
11321132 $dbr = wfGetDB( DB_SLAVE );
@@ -1158,7 +1158,7 @@
11591159 $dbw->commit();
11601160 }
11611161
1162 - function updateLock ( $noticeName, $isLocked ) {
 1162+ function updateLock( $noticeName, $isLocked ) {
11631163 global $wgOut;
11641164
11651165 $dbr = wfGetDB( DB_SLAVE );
@@ -1303,7 +1303,7 @@
13041304 $dbw->commit();
13051305 }
13061306
1307 - function dropDownList ( $text, $values ) {
 1307+ function dropDownList( $text, $values ) {
13081308 $dropDown = "* {$text}\n";
13091309 foreach ( $values as $value ) {
13101310 $dropDown .= "**{$value}\n";
@@ -1311,7 +1311,7 @@
13121312 return $dropDown;
13131313 }
13141314
1315 - function addZero ( $text ) {
 1315+ function addZero( $text ) {
13161316 // Prepend a 0 for text needing it
13171317 if ( strlen( $text ) == 1 ) {
13181318 $text = "0{$text}";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71608new query added in r71580 doesn't work correctly, fixing (albeit with an ugly...kaldari00:46, 25 August 2010

Status & tagging log