r71586 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71585‎ | r71586 | r71587 >
Date:21:10, 24 August 2010
Author:kaldari
Status:ok
Tags:
Comment:
localizing 'Settings' per comment at r71004
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.i18n.php (modified) (history)
  • /trunk/extensions/CentralNotice/SpecialNoticeTemplate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/CentralNotice.i18n.php
@@ -96,6 +96,7 @@
9797 Add one below.',
9898 'centralnotice-no-templates-translate' => 'There are not any banners to edit translations for.',
9999 'centralnotice-number-uses' => 'Uses',
 100+ 'centralnotice-settings' => 'Settings',
100101 'centralnotice-edit-template' => 'Edit banner',
101102 'centralnotice-edit-template-summary' => 'To create a localizable message, enclose a hyphenated string in three curly brackets, e.g. {{{jimbo-quote}}}.',
102103 'centralnotice-message' => 'Message',
Index: trunk/extensions/CentralNotice/SpecialNoticeTemplate.php
@@ -430,7 +430,7 @@
431431 }
432432
433433 // Show banner settings
434 - $htmlOut .= Xml::fieldset( 'Settings' );
 434+ $htmlOut .= Xml::fieldset( wfMsg( 'centralnotice-settings' ) );
435435 $htmlOut .= Xml::openElement( 'p', null );
436436 $htmlOut .= wfMsg( 'centralnotice-banner-display' );
437437 $htmlOut .= Xml::check( 'displayAnon', ( $row->tmp_display_anon == 1 ), wfArrayMerge( $disabled, array( 'id' => 'displayAnon' ) ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71004allow control of whether banners are displayed to anon and/or logged in userskaldari01:52, 13 August 2010

Status & tagging log