r71569 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71568‎ | r71569 | r71570 >
Date:17:28, 24 August 2010
Author:tkriplean
Status:deferred
Tags:
Comment:
comment should use elements property to access children
Modified paths:
  • /trunk/extensions/Reflect/client/js/reflect.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Reflect/client/js/reflect.js
@@ -765,7 +765,7 @@
766766 return;
767767 }
768768
769 - if ( comment.$elem.find( '.new_bullet' ).length == 0 ) {
 769+ if ( comment.elements.bullet_list.find( '.new_bullet' ).length == 0 ) {
770770 var new_bullet = comment.add_bullet_prompt();
771771 new_bullet.$elem.children( 'button' )
772772 .bind( 'click', Reflect.transitions.to_bullet, false );
@@ -875,7 +875,7 @@
876876 Reflect.transitions.to_base( bullet_obj.comment.id );
877877 } );
878878
879 - if ( bullet_obj.comment.$elem.find( '.highlight' ).length == 0 ) {
 879+ if ( bullet_obj.comment.elements.comment_text.find( '.highlight' ).length == 0 ) {
880880 bullet_obj.elements.submit_button.attr( 'disabled', true );
881881 }
882882
@@ -1536,7 +1536,7 @@
15371537 }
15381538 // segment sentences we can index them during highlighting
15391539 comment.elements.comment_text.wrap_sentences();
1540 - comment.$elem.find( '.sentence' )
 1540+ comment.elements.comment_text.find( '.sentence' )
15411541 .each( function ( index ) {
15421542 $j( this ).attr( 'id', 'sentence-' + index )
15431543 .click( Reflect.handle.sentence_click );

Status & tagging log