r71563 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71562‎ | r71563 | r71564 >
Date:14:49, 24 August 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Documentation and style improvements
Modified paths:
  • /trunk/extensions/Maps/Features/DisplayMap/Maps_BaseMap.php (modified) (history)
  • /trunk/extensions/Maps/Features/DisplayPoint/Maps_BasePointMap.php (modified) (history)
  • /trunk/extensions/Maps/Features/iMappingFeature.php (modified) (history)
  • /trunk/extensions/Maps/Features/iMappingParserFunction.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Features/DisplayPoint/Maps_BasePointMap.php
@@ -1,23 +1,11 @@
22 <?php
33
44 /**
5 - * File holding class MapsBasePointMap.
6 - *
7 - * @file Maps_BasePointMap.php
8 - * @ingroup Maps
9 - *
10 - * @author Jeroen De Dauw
11 - */
12 -
13 -if ( !defined( 'MEDIAWIKI' ) ) {
14 - die( 'Not an entry point.' );
15 -}
16 -
17 -/**
185 * Abstract class MapsBasePointMap provides the scafolding for classes handling display_point(s)
196 * calls for a specific mapping service. It inherits from MapsMapFeature and therefore forces
207 * inheriting classes to implement sereveral methods.
218 *
 9+ * @file Maps_BasePointMap.php
2210 * @ingroup Maps
2311 *
2412 * @author Jeroen De Dauw
Index: trunk/extensions/Maps/Features/DisplayMap/Maps_BaseMap.php
@@ -1,23 +1,11 @@
22 <?php
33
44 /**
5 - * File holding class MapsBaseMap.
6 - *
7 - * @file Maps_BaseMap.php
8 - * @ingroup Maps
9 - *
10 - * @author Jeroen De Dauw
11 - */
12 -
13 -if ( !defined( 'MEDIAWIKI' ) ) {
14 - die( 'Not an entry point.' );
15 -}
16 -
17 -/**
185 * Abstract class MapsBaseMap provides the scafolding for classes handling display_map
196 * calls for a specific mapping service. It inherits from MapsMapFeature and therefore
207 * forces inheriting classes to implement sereveral methods.
218 *
 9+ * @file Maps_BaseMap.php
2210 * @ingroup Maps
2311 *
2412 * @author Jeroen De Dauw
Index: trunk/extensions/Maps/Features/iMappingFeature.php
@@ -1,25 +1,15 @@
22 <?php
33
44 /**
5 - * File holding interface iMappingFeature.
 5+ * Interface that should be implemented by all mapping features that want to use the.
66 *
 7+ * @since 0.6.5
 8+ *
79 * @file iMappingFeature.php
810 * @ingroup Maps
911 *
1012 * @author Jeroen De Dauw
1113 */
12 -
13 -if ( !defined( 'MEDIAWIKI' ) ) {
14 - die( 'Not an entry point.' );
15 -}
16 -
17 -/**
18 - * Interface that should be implemented by all mapping features that want to use the.
19 - *
20 - * @since 0.6.5
21 - *
22 - * @author Jeroen De Dauw
23 - */
2414 interface iMappingFeature {
2515
2616 /**
Index: trunk/extensions/Maps/Features/iMappingParserFunction.php
@@ -1,25 +1,15 @@
22 <?php
33
44 /**
5 - * File holding interface iMappingParserFunction.
 5+ * Interface that should be implemented by all map display parser functions.
66 *
 7+* @since 0.6.3
 8+ *
79 * @file iMappingParserFunction.php
810 * @ingroup Maps
911 *
1012 * @author Jeroen De Dauw
1113 */
12 -
13 -if ( !defined( 'MEDIAWIKI' ) ) {
14 - die( 'Not an entry point.' );
15 -}
16 -
17 -/**
18 - * Interface that should be implemented by all map display parser functions.
19 - *
20 - * @author Jeroen De Dauw
21 - *
22 - * @since 0.6.3
23 - */
2414 interface iMappingParserFunction extends iMappingFeature {
2515
2616 /**
@@ -39,4 +29,5 @@
4030 * @return array
4131 */
4232 function getMapHtml( Parser &$parser, array $params );
 33+
4334 }
\ No newline at end of file

Status & tagging log