r71537 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r71536‎ | r71537 | r71538 >
Date:00:38, 24 August 2010
Author:reedy
Status:deferred
Tags:
Comment:
PRIMARY KEY (aa_page_id, aa_revision) isn't unique for article_assessment_pages

Adding aa_dimension to key ('works' for the moment, till it's sorted properly,otherwise INSERT INTO mw_article_assessment_pages(aa_page_id, aa_revision, aa_total, aa_count, aa_dimension) VALUES(1, 33, 10, 2, 1), (1, 33, 10, 2, 2), (1, 33, 10, 2, 3), (1, 33, 10, 2, 4); would fail)
Modified paths:
  • /trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.sql
——@@ -27,5 +27,5 @@
2828 aa_total integer unsigned NOT NULL,
2929 aa_count integer unsigned NOT NULL,
3030 aa_dimension integer unsigned NOT NULL,
31 - PRIMARY KEY (aa_page_id, aa_revision)
 31+ PRIMARY KEY (aa_page_id, aa_revision, aa_dimension)
3232 ) /*$wgDBTableOptions*/;
\ No newline at end of file

Status & tagging log