r71529 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71528‎ | r71529 | r71530 >
Date:23:40, 23 August 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Fixed bug where an empty comment broke the import of trxns
Modified paths:
  • /civicrm/trunk/sites/all/modules/queue2civicrm/queue2civicrm.module (modified) (history)

Diff [purge]

Index: civicrm/trunk/sites/all/modules/queue2civicrm/queue2civicrm.module
@@ -301,7 +301,7 @@
302302 $dao = CRM_Core_DAO::executeQuery( $query ); // Execute's query using CiviCRM data object stuff
303303 while ( $dao->fetch() ) {
304304 if ( $dao->label == 'Donor Comment' ) {
305 - $comment = ( $msg[ 'comment' ] ) ? $msg[ 'comment'] : $dao->default_value;
 305+ $comment = ( $msg[ 'comment' ] ) ? $msg[ 'comment'] : '';
306306 $contribution[ 'custom_' . $dao->id ] = $comment;
307307 } elseif ( $dao->default_value ) { // if we dont make sure $dao->default_value has some value, Civi breaks when we try to insert
308308 $contribution[ 'custom_' . $dao->id ] = $dao->default_value;

Status & tagging log