r71515 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71514‎ | r71515 | r71516 >
Date:21:54, 23 August 2010
Author:platonides
Status:ok
Tags:
Comment:
Try to improve the funciton comment of getETag() per r70809 CR. Adaptation of Nikerabbit proposal.
Modified paths:
  • /trunk/phase3/includes/parser/ParserCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/ParserCache.php
@@ -55,10 +55,14 @@
5656 }
5757
5858 /**
59 - * Provides an E-Tag suitable for the whole page, even if $article is
60 - * just the main wikitext. So it uses the complete set of user options.
61 - * Most importantly, that includes the user language, but other options
62 - * would give problems on some setups, too.
 59+ * Provides an E-Tag suitable for the whole page. Note that $article
 60+ * is just the main wikitext. The E-Tag has to be unique to the whole
 61+ * page, even if the article itself is the same, so it uses the
 62+ * complete set of user options. We don't want to use the preference
 63+ * of a different user on a message just because it wasn't used in
 64+ * $article. For example give a Chinese interface to a user with
 65+ * English preferences. That's why we take into account *all* user
 66+ * options. (r70809 CR)
6367 */
6468 function getETag( $article, $popts ) {
6569 return 'W/"' . $this->getParserOutputKey( $article,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70809Follow up r70783 CR....platonides12:10, 10 August 2010

Status & tagging log