r71420 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71419‎ | r71420 | r71421 >
Date:22:11, 21 August 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r71359. $wgDBtype uneeded now.
Modified paths:
  • /trunk/phase3/maintenance/convertLinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/convertLinks.php
@@ -36,8 +36,6 @@
3737 }
3838
3939 public function execute() {
40 - global $wgDBtype;
41 -
4240 $dbw = wfGetDB( DB_MASTER );
4341
4442 $type = $dbw->getType();
@@ -124,8 +122,9 @@
125123 $dbw->bufferResults( true );
126124 $this->output( "Finished loading IDs.\n\n" );
127125 $this->performanceLog( "Took " . ( $this->getMicroTime() - $baseTime ) . " seconds to load IDs.\n\n" );
128 - # --------------------------------------------------------------------
129126
 127+ # --------------------------------------------------------------------
 128+
130129 # Now, step through the links table (in chunks of $linksConvInsertInterval rows),
131130 # convert, and write to the new table.
132131 $this->createTempTable();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71359Refactor convertLinks to not use DB::newFromParams() crap, make updaters use ...demon14:47, 20 August 2010

Status & tagging log