r71414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71413‎ | r71414 | r71415 >
Date:18:20, 21 August 2010
Author:ialex
Status:ok
Tags:
Comment:
* Added file description headers
* Added @file where needed
Modified paths:
  • /trunk/phase3/includes/installer/CliInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/DatabaseInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)
  • /trunk/phase3/includes/installer/LocalSettingsGenerator.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/OracleInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/PostgresInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/PostgresUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/SqliteInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/SqliteUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerOutput.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -1,5 +1,11 @@
22 <?php
3 -
 3+/**
 4+ * DBMS-specific updater helper.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
 9+
410 /*
511 * Class for handling database updates. Roughly based off of updaters.inc, with
612 * a few improvements :)
Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -1,4 +1,10 @@
22 <?php
 3+/**
 4+ * MySQL-specific updater.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
39
410 /**
511 * Mysql update list and mysql-specific update functions.
Index: trunk/phase3/includes/installer/PostgresUpdater.php
@@ -1,6 +1,12 @@
22 <?php
3 -
43 /**
 4+ * PostgreSQL-specific updater.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
 9+
 10+/**
511 * Class for handling updates to Postgres databases.
612 *
713 * @todo FIXME: Postgres should use sequential updates like Mysql, Sqlite
Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -1,4 +1,10 @@
22 <?php
 3+/**
 4+ * Core installer web interface.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
39
410 /**
511 * Class for the core installer web interface.
Index: trunk/phase3/includes/installer/Installer.php
@@ -1,4 +1,10 @@
22 <?php
 3+/**
 4+ * Base code for MediaWiki installer.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
39
410 /**
511 * This documentation group collects source code files with deployment functionality.
@@ -804,7 +810,7 @@
805811
806812 /**
807813 * Convert a hex string representing a Unicode code point to that code point.
808 - * @param string $c
 814+ * @param $c String
809815 * @return string
810816 */
811817 protected function unicodeChar( $c ) {
Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -1,4 +1,10 @@
22 <?php
 3+/**
 4+ * Base core installer.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
39
410 /**
511 * Base core installer class.
@@ -171,7 +177,7 @@
172178 /**
173179 * TODO: document
174180 *
175 - * @param Status $status
 181+ * @param $status Status
176182 */
177183 public abstract function showStatusMessage( Status $status );
178184
@@ -307,8 +313,8 @@
308314 /**
309315 * Actually perform the installation.
310316 *
311 - * @param Array $startCB A callback array for the beginning of each step
312 - * @param Array $endCB A callback array for the end of each step
 317+ * @param $startCB A callback array for the beginning of each step
 318+ * @param $endCB A callback array for the end of each step
313319 *
314320 * @return Array of Status objects
315321 */
Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -1,8 +1,11 @@
22 <?php
3 -/*
 3+/**
44 * Internationalization file for the install/upgrade process. None of the
55 * messages used here are loaded during normal operations, only during
66 * install and upgrade. So you should not put normal messages here.
 7+ *
 8+ * @file
 9+ * @ingroup Deployment
710 */
811
912 $messages = array();
Index: trunk/phase3/includes/installer/WebInstallerOutput.php
@@ -1,4 +1,10 @@
22 <?php
 3+/**
 4+ * Output handler for the web installer.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
39
410 /**
511 * Output class modelled on OutputPage.
Index: trunk/phase3/includes/installer/SqliteInstaller.php
@@ -1,6 +1,12 @@
22 <?php
3 -
43 /**
 4+ * Sqlite-specific installer.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
 9+
 10+/**
511 * Class for setting up the MediaWiki database using SQLLite.
612 *
713 * @ingroup Deployment
Index: trunk/phase3/includes/installer/DatabaseInstaller.php
@@ -1,4 +1,10 @@
22 <?php
 3+/**
 4+ * DBMS-specific installation helper.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
39
410 /**
511 * Base class for DBMS-specific installation helper classes.
Index: trunk/phase3/includes/installer/LocalSettingsGenerator.php
@@ -1,7 +1,13 @@
22 <?php
 3+/**
 4+ * Generator for LocalSettings.php file.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
39
410 /**
5 - * Class for manipulating LocalSettings.
 11+ * Class for generating LocalSettings.php file.
612 *
713 * @ingroup Deployment
814 * @since 1.17
Index: trunk/phase3/includes/installer/MysqlInstaller.php
@@ -1,4 +1,10 @@
22 <?php
 3+/**
 4+ * MySQL-specific installer.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
39
410 /**
511 * Class for setting up the MediaWiki database using MySQL.
Index: trunk/phase3/includes/installer/OracleInstaller.php
@@ -1,6 +1,12 @@
22 <?php
3 -
43 /**
 4+ * Oracle-specific installer.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
 9+
 10+/**
511 * Class for setting up the MediaWiki database using Oracle.
612 *
713 * @ingroup Deployment
Index: trunk/phase3/includes/installer/PostgresInstaller.php
@@ -1,6 +1,12 @@
22 <?php
3 -
43 /**
 4+ * PostgreSQL-specific installer.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
 9+
 10+/**
511 * Class for setting up the MediaWiki database using Postgres.
612 *
713 * @ingroup Deployment
Index: trunk/phase3/includes/installer/CliInstaller.php
@@ -1,4 +1,10 @@
22 <?php
 3+/**
 4+ * Core installer command line interface.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
39
410 /**
511 * Class for the core installer command line interface.
Index: trunk/phase3/includes/installer/SqliteUpdater.php
@@ -1,6 +1,12 @@
22 <?php
3 -
43 /**
 4+ * Sqlite-specific updater.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
 9+
 10+/**
511 * Class for handling updates to Sqlite databases.
612 *
713 * @ingroup Deployment
Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -1,4 +1,10 @@
22 <?php
 3+/**
 4+ * Base code for web installer pages.
 5+ *
 6+ * @file
 7+ * @ingroup Deployment
 8+ */
39
410 /**
511 * Abstract class to define pages for the web installer.

Status & tagging log