r71403 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71402‎ | r71403 | r71404 >
Date:14:53, 21 August 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r71289. getServerVersion() call was needed to initialise numeric_version.
In fact, we can use getServerVersion() here.
Modified paths:
  • /trunk/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/updaters.inc
@@ -1210,8 +1210,8 @@
12111211 function do_postgres_updates() {
12121212 global $wgDatabase, $wgDBmwschema, $wgDBts2schema, $wgDBuser;
12131213
1214 - # # Gather version numbers in case we need them
1215 - $numver = $wgDatabase->numeric_version; # # X.Y e.g. 8.3
 1214+ # Gather version numbers in case we need them
 1215+ $numver = $wgDatabase->getServerVersion();
12161216
12171217 # Just in case their LocalSettings.php does not have this:
12181218 if ( !isset( $wgDBmwschema ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71289More unused....reedy11:42, 19 August 2010

Status & tagging log