r71389 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71388‎ | r71389 | r71390 >
Date:08:15, 21 August 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Mostly indentation fixes
Modified paths:
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
@@ -737,7 +737,7 @@
738738 'media_type' => MEDIATYPE_BITMAP,
739739 'mime' => 'image/jpeg',
740740 'metadata' => serialize( array() ),
741 - 'sha1' => sha1(''),
 741+ 'sha1' => sha1(''),
742742 'fileExists' => true
743743 ), $db->timestamp( '20010115123500' ), $user );
744744
@@ -1346,22 +1346,22 @@
13471347 }
13481348
13491349 /**
1350 - ** Returns a string giving information about when a test last had a status change.
1351 - ** Could help to track down when regressions were introduced, as distinct from tests
1352 - ** which have never passed (which are more change requests than regressions).
 1350+ * Returns a string giving information about when a test last had a status change.
 1351+ * Could help to track down when regressions were introduced, as distinct from tests
 1352+ * which have never passed (which are more change requests than regressions).
13531353 */
13541354 private function getTestStatusInfo( $testname, $after ) {
13551355
13561356 // If we're looking at a test that has just been removed, then say when it first appeared.
13571357 if ( $after == 'n' ) {
13581358 $changedRun = $this->db->selectField ( 'testitem',
1359 - 'MIN(ti_run)',
1360 - array( 'ti_name' => $testname ),
1361 - __METHOD__ );
 1359+ 'MIN(ti_run)',
 1360+ array( 'ti_name' => $testname ),
 1361+ __METHOD__ );
13621362 $appear = $this->db->selectRow ( 'testrun',
1363 - array( 'tr_date', 'tr_mw_version' ),
1364 - array( 'tr_id' => $changedRun ),
1365 - __METHOD__ );
 1363+ array( 'tr_date', 'tr_mw_version' ),
 1364+ array( 'tr_id' => $changedRun ),
 1365+ __METHOD__ );
13661366 return "First recorded appearance: "
13671367 . date( "d-M-Y H:i:s", strtotime ( $appear->tr_date ) )
13681368 . ", " . $appear->tr_mw_version;
@@ -1391,15 +1391,15 @@
13921392 // (i.e. it used to work, but now doesn't; or used to fail, but is now fixed.)
13931393 // In this situation, give as much info as we can as to when it changed status.
13941394 $pre = $this->db->selectRow ( 'testrun',
1395 - array( 'tr_date', 'tr_mw_version' ),
1396 - array( 'tr_id' => $changedRun ),
1397 - __METHOD__ );
 1395+ array( 'tr_date', 'tr_mw_version' ),
 1396+ array( 'tr_id' => $changedRun ),
 1397+ __METHOD__ );
13981398 $post = $this->db->selectRow ( 'testrun',
1399 - array( 'tr_date', 'tr_mw_version' ),
1400 - array( "tr_id > " . $this->db->addQuotes ( $changedRun ) ),
1401 - __METHOD__,
1402 - array( "LIMIT" => 1, "ORDER BY" => 'tr_id' )
1403 - );
 1399+ array( 'tr_date', 'tr_mw_version' ),
 1400+ array( "tr_id > " . $this->db->addQuotes ( $changedRun ) ),
 1401+ __METHOD__,
 1402+ array( "LIMIT" => 1, "ORDER BY" => 'tr_id' )
 1403+ );
14041404
14051405 if ( $post ) {
14061406 $postDate = date( "d-M-Y H:i:s", strtotime ( $post->tr_date ) ) . ", {$post->tr_mw_version}";

Status & tagging log