r71372 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71371‎ | r71372 | r71373 >
Date:18:03, 20 August 2010
Author:platonides
Status:ok
Tags:
Comment:
Revert the change to Preprocessor_DOM.php of r71286.
The parsertest "Link with 3 brackets" passes again.
Modified paths:
  • /trunk/phase3/includes/parser/Preprocessor_DOM.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Preprocessor_DOM.php
@@ -612,7 +612,7 @@
613613 # do we still qualify for any callback with remaining count?
614614 $names = $rules[$piece->open]['names'];
615615 $skippedBraces = 0;
616 -
 616+ $enclosingAccum =& $accum;
617617 while ( $piece->count ) {
618618 if ( array_key_exists( $piece->count, $names ) ) {
619619 $stack->push( $piece );
@@ -622,6 +622,7 @@
623623 --$piece->count;
624624 $skippedBraces ++;
625625 }
 626+ $enclosingAccum .= str_repeat( $piece->open, $skippedBraces );
626627 }
627628 $flags = $stack->getFlags();
628629 extract( $flags );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71286Remove some more unused variables...reedy11:21, 19 August 2010

Status & tagging log