r71349 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71348‎ | r71349 | r71350 >
Date:12:28, 20 August 2010
Author:daniel
Status:deferred
Tags:
Comment:
Inserter interface changes
Modified paths:
  • /trunk/WikiWord/WikiWordBuilder/src/main/java/de/brightbyte/wikiword/store/builder/DatabaseLocalConceptStoreBuilder.java (modified) (history)
  • /trunk/WikiWord/WikiWordBuilder/src/main/java/de/brightbyte/wikiword/store/builder/DatabaseLocalPropertyStoreBuilder.java (modified) (history)
  • /trunk/WikiWord/WikiWordBuilder/src/main/java/de/brightbyte/wikiword/store/builder/DatabaseWikiWordConceptStoreBuilder.java (modified) (history)

Diff [purge]

Index: trunk/WikiWord/WikiWordBuilder/src/main/java/de/brightbyte/wikiword/store/builder/DatabaseLocalPropertyStoreBuilder.java
@@ -54,7 +54,7 @@
5555
5656 this.propertyInserter = configureTable("property", 128, 3*32);
5757 this.propertyTable = (RelationTable)propertyInserter.getTable();
58 - propertyInserter.setLenient(true); //skip dupes
 58+ propertyInserter.setOnDuplicateKey("IGNORE"); //skip dupes
5959
6060 this.conceptStoreSchema = conceptStoreSchema;
6161 this.idManager = idManager;
Index: trunk/WikiWord/WikiWordBuilder/src/main/java/de/brightbyte/wikiword/store/builder/DatabaseLocalConceptStoreBuilder.java
@@ -131,7 +131,7 @@
132132 definitionInserter = configureTable("definition", 1024, 256);
133133 resourceInserter = configureTable("resource", 256, 32);
134134 aliasInserter = configureTable("alias", 1024, 64);
135 - aliasInserter.setLenient(true);
 135+ aliasInserter.setOnDuplicateKey("IGNORE");
136136 meaningInserter = configureTable("meaning", 8*1024, 64);
137137
138138 resourceTable = (EntityTable)resourceInserter.getTable();
Index: trunk/WikiWord/WikiWordBuilder/src/main/java/de/brightbyte/wikiword/store/builder/DatabaseWikiWordConceptStoreBuilder.java
@@ -58,7 +58,7 @@
5959 linkInserter = configureTable("link", 8*1024, 64);
6060 langlinkInserter = configureTable("langlink", 2*1024, 64);
6161
62 - langlinkInserter.setLenient(true);
 62+ langlinkInserter.setOnDuplicateKey("IGNORE");
6363
6464 conceptTable = (EntityTable)conceptInserter.getTable();
6565 broaderTable = (RelationTable)broaderInserter.getTable();

Status & tagging log