r71347 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71346‎ | r71347 | r71348 >
Date:11:03, 20 August 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Alter code constructions that confuse the hell out of doxygen
Modified paths:
  • /trunk/extensions/Translate/FFS.php (modified) (history)
  • /trunk/extensions/Translate/ffs/OpenLayers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/FFS.php
@@ -494,8 +494,8 @@
495495 /**
496496 * Strip excess whitespace from key and value, then quotation marks.
497497 */
498 - $key = trim( trim( $segments[0] ), '\'"' );
499 - $value = trim( trim( $segments[1] ), '\'"' );
 498+ $key = trim( trim( $segments[0] ), "'\"" );
 499+ $value = trim( trim( $segments[1] ), "'\"" );
500500
501501 /**
502502 * Unescape any JavaScript string syntax and append to message array.
Index: trunk/extensions/Translate/ffs/OpenLayers.php
@@ -29,7 +29,7 @@
3030
3131 # Work around https://bugzilla.mozilla.org/show_bug.cgi?id=274152
3232 # Encode certain Unicode formatting chars so affected
33 - # versions of Gecko don't misinterpret our strings;
 33+ # versions of Gecko do not misinterpret our strings;
3434 # this is a common problem with Farsi text.
3535 "\xe2\x80\x8c" => "\\u200c", // ZERO WIDTH NON-JOINER
3636 "\xe2\x80\x8d" => "\\u200d", // ZERO WIDTH JOINER
@@ -86,7 +86,7 @@
8787 # $segment = preg_replace( '#\" \+(.*?)\"#m', '', $segment );
8888 // Break in to key and message.
8989 if ( $this->keyquote ) {
90 - $segments = explode( '\':', $segment );
 90+ $segments = explode( "':", $segment );
9191 } else {
9292 $segments = explode( ': ', $segment );
9393 }

Status & tagging log