r71271 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r71270‎ | r71271 | r71272 >
Date:20:34, 18 August 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup to r68338, remove useless code (row is overwritten by loop)
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
——@@ -132,7 +132,6 @@
133133 // The setContinue... is more complex because of this, and takes into account the higher sql limit
134134 // to make sure all rows that belong to the same user are received.
135135
136 - $row = $db->fetchObject( $res );
137136 foreach ( $res as $row ) {
138137 $count++;
139138

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68338Do ApiQueryAllUsers per r68337 (was using while (true)..)reedy18:52, 20 June 2010

Comments

#Comment by Bryan (talk | contribs)   19:36, 10 September 2010

Note that you are no longer skipping a row. Is that intentional?

#Comment by Catrope (talk | contribs)   11:54, 27 September 2010

I think the skipped row was actually a bug.

Status & tagging log