r71185 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71184‎ | r71185 | r71186 >
Date:02:07, 17 August 2010
Author:tstarling
Status:ok
Tags:
Comment:
* Fix non-static call of static function
* Fixed two spelling errors in comments
Modified paths:
  • /trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php
@@ -305,7 +305,7 @@
306306 return new ThumbnailImage( $image, $dstUrl, $width, $height, $dstPath, $page );
307307 }
308308
309 - if ( !$this->extCheck( $meta, $error, $dstPath ) ) {
 309+ if ( !self::extCheck( $meta, $error, $dstPath ) ) {
310310 return $this->doThumbError( $params, $error );
311311 }
312312
@@ -412,14 +412,14 @@
413413 // thumbnail size seems sane.
414414 $sz = $wgUser->getOption( 'thumbsize' );
415415 $width = $wgThumbLimits[ $sz ];
416 - $height = $width; // we don't have a hight or aspect ratio. make it square.
 416+ $height = $width; // we don't have a height or aspect ratio. make it square.
417417 } else {
418418 $width = intval( $params['width'] );
419419
420420 if ( !empty( $params['height'] ) ) {
421421 $height = intval( $params['height'] );
422422 } else {
423 - $height = $width; // we don't have a hight or aspect ratio. make it square.
 423+ $height = $width; // we don't have a height or aspect ratio. make it square.
424424 }
425425 }
426426

Status & tagging log