r71162 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71161‎ | r71162 | r71163 >
Date:13:16, 16 August 2010
Author:demon
Status:ok
Tags:
Comment:
Remove unused rename_table() and PG override of $wgShowExceptionDetails. Less updaters.inc is good :)
Modified paths:
  • /trunk/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/updaters.inc
@@ -43,23 +43,6 @@
4444 return (bool)$row;
4545 }
4646
47 -function rename_table( $from, $to, $patch ) {
48 - global $wgDatabase;
49 - if ( $wgDatabase->tableExists( $from ) ) {
50 - if ( $wgDatabase->tableExists( $to ) ) {
51 - wfOut( "...can't move table $from to $to, $to already exists.\n" );
52 - } else {
53 - wfOut( "Moving table $from to $to..." );
54 - $wgDatabase->sourceFile( archive( $patch ) );
55 - wfOut( "ok\n" );
56 - }
57 - } else {
58 - // Source table does not exist
59 - // Renames are done before creations, so this is typical for a new installation
60 - // Ignore silently
61 - }
62 -}
63 -
6447 function add_table( $name, $patch, $fullpath = false ) {
6548 global $wgDatabase;
6649 if ( $wgDatabase->tableExists( $name ) ) {
@@ -1316,8 +1299,6 @@
13171300 $version = $wgDatabase->getServerVersion(); # # long string
13181301 $numver = $wgDatabase->numeric_version; # # X.Y e.g. 8.3
13191302
1320 - $wgShowExceptionDetails = 1;
1321 -
13221303 # Just in case their LocalSettings.php does not have this:
13231304 if ( !isset( $wgDBmwschema ) ) {
13241305 $wgDBmwschema = 'mediawiki';

Status & tagging log