r71134 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71133‎ | r71134 | r71135 >
Date:17:27, 15 August 2010
Author:ialex
Status:ok
Tags:
Comment:
* Standardised file description headers
* Added some descriptions
Modified paths:
  • /trunk/phase3/includes/media/BMP.php (modified) (history)
  • /trunk/phase3/includes/media/Bitmap.php (modified) (history)
  • /trunk/phase3/includes/media/Bitmap_ClientOnly.php (modified) (history)
  • /trunk/phase3/includes/media/DjVu.php (modified) (history)
  • /trunk/phase3/includes/media/GIF.php (modified) (history)
  • /trunk/phase3/includes/media/GIFMetadataExtractor.php (modified) (history)
  • /trunk/phase3/includes/media/Generic.php (modified) (history)
  • /trunk/phase3/includes/media/MediaTransformOutput.php (modified) (history)
  • /trunk/phase3/includes/media/PNG.php (modified) (history)
  • /trunk/phase3/includes/media/PNGMetadataExtractor.php (modified) (history)
  • /trunk/phase3/includes/media/SVG.php (modified) (history)
  • /trunk/phase3/includes/media/Tiff.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Bitmap.php
@@ -1,10 +1,14 @@
22 <?php
33 /**
 4+ * Generic handler for bitmap images
 5+ *
46 * @file
57 * @ingroup Media
68 */
79
810 /**
 11+ * Generic handler for bitmap images
 12+ *
913 * @ingroup Media
1014 */
1115 class BitmapHandler extends ImageHandler {
Index: trunk/phase3/includes/media/Bitmap_ClientOnly.php
@@ -1,5 +1,19 @@
22 <?php
 3+/**
 4+ * Handler for bitmap images that will be resized by clients
 5+ *
 6+ * @file
 7+ * @ingroup Media
 8+ */
39
 10+/**
 11+ * Handler for bitmap images that will be resized by clients.
 12+ *
 13+ * This is not used by default but can be assigned to some image types
 14+ * using $wgMediaHandlers.
 15+ *
 16+ * @ingroup Media
 17+ */
418 class BitmapHandler_ClientOnly extends BitmapHandler {
519 function normaliseParams( $image, &$params ) {
620 return parent::normaliseParams( $image, $params );
Index: trunk/phase3/includes/media/Generic.php
@@ -1,6 +1,7 @@
22 <?php
33 /**
44 * Media-handling base classes and generic functionality
 5+ *
56 * @file
67 * @ingroup Media
78 */
Index: trunk/phase3/includes/media/MediaTransformOutput.php
@@ -1,5 +1,7 @@
22 <?php
33 /**
 4+ * Base class for the output of file transformation methods.
 5+ *
46 * @file
57 * @ingroup Media
68 */
Index: trunk/phase3/includes/media/BMP.php
@@ -1,5 +1,7 @@
22 <?php
33 /**
 4+ * Handler for Microsoft's bitmap format
 5+ *
46 * @file
57 * @ingroup Media
68 */
Index: trunk/phase3/includes/media/SVG.php
@@ -1,10 +1,14 @@
22 <?php
33 /**
 4+ * Handler for SVG images.
 5+ *
46 * @file
57 * @ingroup Media
68 */
79
810 /**
 11+ * Handler for SVG images.
 12+ *
913 * @ingroup Media
1014 */
1115 class SvgHandler extends ImageHandler {
Index: trunk/phase3/includes/media/PNGMetadataExtractor.php
@@ -1,11 +1,19 @@
22 <?php
33 /**
4 - * PNG frame counter.
5 - * Slightly derived from GIFMetadataExtractor.php
6 - * Deliberately not using MWExceptions to avoid external dependencies, encouraging
7 - * redistribution.
8 - */
 4+ * PNG frame counter.
 5+ * Slightly derived from GIFMetadataExtractor.php
 6+ * Deliberately not using MWExceptions to avoid external dependencies, encouraging
 7+ * redistribution.
 8+ *
 9+ * @file
 10+ * @ingroup Media
 11+ */
912
 13+/**
 14+ * PNG frame counter.
 15+ *
 16+ * @ingroup Media
 17+ */
1018 class PNGMetadataExtractor {
1119 static $png_sig;
1220 static $CRC_size;
Index: trunk/phase3/includes/media/GIFMetadataExtractor.php
@@ -1,12 +1,21 @@
22 <?php
33 /**
4 - * GIF frame counter.
5 - * Originally written in Perl by Steve Sanbeg.
6 - * Ported to PHP by Andrew Garrett
7 - * Deliberately not using MWExceptions to avoid external dependencies, encouraging
8 - * redistribution.
9 - */
 4+ * GIF frame counter.
 5+ *
 6+ * Originally written in Perl by Steve Sanbeg.
 7+ * Ported to PHP by Andrew Garrett
 8+ * Deliberately not using MWExceptions to avoid external dependencies, encouraging
 9+ * redistribution.
 10+ *
 11+ * @file
 12+ * @ingroup Media
 13+ */
1014
 15+/**
 16+ * GIF frame counter.
 17+ *
 18+ * @ingroup Media
 19+ */
1120 class GIFMetadataExtractor {
1221 static $gif_frame_sep;
1322 static $gif_extension_sep;
Index: trunk/phase3/includes/media/PNG.php
@@ -1,5 +1,7 @@
22 <?php
33 /**
 4+ * Handler for PNG images.
 5+ *
46 * @file
57 * @ingroup Media
68 */
Index: trunk/phase3/includes/media/GIF.php
@@ -1,5 +1,7 @@
22 <?php
33 /**
 4+ * Handler for GIF images.
 5+ *
46 * @file
57 * @ingroup Media
68 */
Index: trunk/phase3/includes/media/DjVu.php
@@ -1,10 +1,14 @@
22 <?php
33 /**
 4+ * Handler for DjVu images
 5+ *
46 * @file
57 * @ingroup Media
68 */
79
810 /**
 11+ * Handler for DjVu images
 12+ *
913 * @ingroup Media
1014 */
1115 class DjVuHandler extends ImageHandler {
Index: trunk/phase3/includes/media/Tiff.php
@@ -1,10 +1,14 @@
22 <?php
33 /**
 4+ * Handler for Tiff images.
 5+ *
46 * @file
57 * @ingroup Media
68 */
79
810 /**
 11+ * Handler for Tiff images.
 12+ *
913 * @ingroup Media
1014 */
1115 class TiffHandler extends BitmapHandler {

Status & tagging log