r70985 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70984‎ | r70985 | r70986 >
Date:20:35, 12 August 2010
Author:siebrand
Status:deferred
Tags:
Comment:
Move WikiBlame to new style message group.
Modified paths:
  • /trunk/extensions/Translate/_autoload.php (modified) (history)
  • /trunk/extensions/Translate/groups/WikiBlame (added) (history)
  • /trunk/extensions/Translate/groups/WikiBlame/WikiBlame.yml (added) (history)
  • /trunk/extensions/Translate/groups/Wikiblame.php (deleted) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/Wikiblame.php
@@ -1,55 +0,0 @@
2 -<?php
3 -/**
4 - * Support Wikiblame: http://wikipedia.ramselehof.de/wikiblame.php.
5 - *
6 - * @file
7 - * @ingroup Extensions
8 - *
9 - * @copyright Copyright © 2009, Siebrand Mazeland
10 - * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
11 - *
12 - */
13 -
14 -class WikiblameMessageGroup extends MessageGroupOld {
15 - protected $label = 'Wikiblame';
16 - protected $id = 'out-wikiblame';
17 - protected $type = 'wikiblame';
18 -
19 - protected $fileDir = '__BUG__';
20 -
21 - public function getPath() { return $this->fileDir; }
22 - public function setPath( $value ) { $this->fileDir = $value; }
23 -
24 - protected $optional = array(
25 - 'text_dir',
26 - 'messages\\x5b\'manual_link\'\\x5d',
27 - 'messages\\x5b\'contact_link\'\\x5d',
28 - 'messages\\x5b\'lang_example\'\\x5d',
29 - 'messages\\x5b\'project_example\'\\x5d',
30 - 'messages\\x5b\'binary_in_wp\'\\x5d',
31 - );
32 -
33 - public $header = '<?php
34 -/** Wikiblame
35 - *
36 - */';
37 -
38 - public function getMessageFile( $code ) {
39 - if ( isset( $this->codeMap[$code] ) ) {
40 - $code = $this->codeMap[$code];
41 - }
42 - return "$code.php";
43 - }
44 -
45 - protected function getFileLocation( $code ) {
46 - return $this->fileDir . '/' . $this->getMessageFile( $code );
47 - }
48 -
49 - public function getReader( $code ) {
50 - return new PhpVariablesFormatReader( $this->getFileLocation( $code ) );
51 - }
52 -
53 - public function getWriter() {
54 - return new PhpVariablesFormatWriter( $this );
55 - }
56 -}
Index: trunk/extensions/Translate/groups/WikiBlame/WikiBlame.yml
@@ -0,0 +1,26 @@
 2+BASIC:
 3+ id: out-wikiblame
 4+ label: WikiBlame
 5+ namespace: NS_WIKIMEDIA
 6+ class: FileBasedMessageGroup
 7+ description: "{{int:int:bw-desc-wikiblame}}"
 8+ display: out/wikiblame
 9+
 10+FILES:
 11+ class: FlatPhpFFS
 12+ sourcePattern: %GROUPROOT%/wikiblame/%CODE%.php
 13+ targetPattern: wikiblame/%CODE%.php
 14+ header: |
 15+ <?php
 16+ /** WikiBlame
 17+ *
 18+ */
 19+
 20+TAGS:
 21+ optional:
 22+ - text_dir
 23+ - messages\\x5b\'manual_link\'\\x5d
 24+ - messages\\x5b\'contact_link\'\\x5d
 25+ - messages\\x5b\'lang_example\'\\x5d
 26+ - messages\\x5b\'project_example\'\\x5d
 27+ - messages\\x5b\'binary_in_wp\'\\x5d
Property changes on: trunk/extensions/Translate/groups/WikiBlame/WikiBlame.yml
___________________________________________________________________
Added: svn:eol-style
128 + native
Index: trunk/extensions/Translate/_autoload.php
@@ -96,7 +96,6 @@
9797 $wgAutoloadClasses['PremadeMediawikiExtensionGroups'] = $dir . 'groups/MediaWikiExtensions.php';
9898 $wgAutoloadClasses['PremadeWikiaExtensionGroups'] = $dir . 'groups/Wikia/WikiaExtensions.php';
9999 $wgAutoloadClasses['OpenLayersMessageGroup'] = $dir . 'groups/OpenLayers.php';
100 -$wgAutoloadClasses['WikiblameMessageGroup'] = $dir . 'groups/Wikiblame.php';
101100 $wgAutoloadClasses['MediaWikiMessageChecker'] = $dir . 'groups/MediaWiki/Checker.php';
102101
103102 # complex messages

Status & tagging log