r70974 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70973‎ | r70974 | r70975 >
Date:17:47, 12 August 2010
Author:kaldari
Status:ok
Tags:
Comment:
consistant interface for add and edit forms for CentralNotice banners
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialNoticeTemplate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialNoticeTemplate.php
@@ -407,15 +407,13 @@
408408 '<img src="'.$scriptPath.'/down-arrow.png" style="vertical-align:baseline;"/>' . wfMsg( 'centralnotice-insert', Language::commaList( $buttons ) )
409409 );
410410 $htmlOut .= Xml::textarea( 'templateBody', $body, 60, 20, $readonly );
 411+ $htmlOut .= Xml::closeElement( 'fieldset' );
411412 if ( $this->editable ) {
412413 $htmlOut .= Xml::hidden( 'authtoken', $wgUser->editToken() );
413414 $htmlOut .= Xml::tags( 'div',
414415 array( 'class' => 'cn-buttons' ),
415 - Xml::submitButton( wfMsg( 'centralnotice-modify' ) )
 416+ Xml::submitButton( wfMsg( 'centralnotice-save-banner' ) )
416417 );
417 - }
418 - $htmlOut .= Xml::closeElement( 'fieldset' );
419 - if ( $this->editable ) {
420418 $htmlOut .= Xml::closeElement( 'form' );
421419 }
422420

Status & tagging log